Showing 12 of 14 total issues
Method tail!
has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring. Open
def tail!(options = {}, &block)
lines = []
tail_cmdline = [ "heroku", "logs", "-p #{@pid}", "--tail", @app ? "--app #{@app}" : nil ].compact.join(" ")
previous_line = nil # delay by 1 to avoid rc=status lines
process_completed = false
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method run
has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring. Open
def run(cmd, options = {}, &block)
lines = []
running_pid = nil
logger = options[:logger]
logger.debug "Running: #{cmd}" if logger
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method tail!
has 55 lines of code (exceeds 25 allowed). Consider refactoring. Open
def tail!(options = {}, &block)
lines = []
tail_cmdline = [ "heroku", "logs", "-p #{@pid}", "--tail", @app ? "--app #{@app}" : nil ].compact.join(" ")
previous_line = nil # delay by 1 to avoid rc=status lines
process_completed = false
Method run
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
def run(cmd, options = {}, &block)
lines = []
running_pid = nil
logger = options[:logger]
logger.debug "Running: #{cmd}" if logger
Method processes
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
def processes(&block)
processes = []
cmdline = [ "heroku", "ps", @app ? "--app #{@app}" : nil ].compact.join(" ")
Heroku::Executor.run cmdline, { :logger => logger } do |line|
next if ! line || line[0] == '=' || line.length == 0
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method terminate_process!
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def terminate_process!(pid, timeout)
if timeout
# Delay terminating of the process, usually to let the output flush.
Thread.new(pid, timeout) do |pid, timeout|
begin
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method run_detached!
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def run_detached!(options = {}, &block)
raise Heroku::Commander::Errors::AlreadyRunningError.new({ :pid => @pid }) if running?
@running = true
@pid = nil
@tail = nil
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method read_from
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def read_from(r, pid, options, lines, &block)
Method read_from
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def read_from(r, pid, options, lines, &block)
logger = options[:logger]
while ! r.eof do
line = r.readline
line.strip! if line
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method run_attached!
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def run_attached!(options = {}, &block)
@pid = nil
previous_line = nil # delay by 1 to avoid rc=status line
lines_until_pid = 0
lines = Heroku::Executor.run cmdline, { :logger => logger } do |line|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method check_exit_status!
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def check_exit_status!(lines)
status = (lines.size > 0) && (match = lines[-1].match(/^rc=(\d+)$/)) ? match[1] : nil
lines.pop if status
raise Heroku::Commander::Errors::CommandError.new({
:cmd => @command,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method cmdline
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def cmdline(options = {})
[
"heroku", options[:detached] ? "run:detached" : "run",
@size ? "--size=#{@size}" : nil,
"\"(#{command} 2>&1 ; echo rc=\\$?)\"",
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"