Sign upLogin

dblock/slack-ruby-bot

View on GitHub
Star

Showing 14 of 14 total issues

Method invoke has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

        def invoke(client, data)
          finalize_routes!
          expression, text = parse(client, data)
          return false unless expression || data.attachments
Severity: Minor
Found in lib/slack-ruby-bot/commands/base.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method names has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def names
      [
        SlackRubyBot::Config.user,
        self.self ? self.self.name : nil,
        aliases ? aliases.map(&:downcase) : nil,
Severity: Minor
Found in lib/slack-ruby-bot/client.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Base has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Base
      include Loggable

      class << self
        attr_accessor :command_classes
Severity: Minor
Found in lib/slack-ruby-bot/commands/base.rb - About 2 hrs to fix

    Method invoke has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def invoke(client, data)
          finalize_routes!
          expression, text = parse(client, data)
          return false unless expression || data.attachments
    Severity: Minor
    Found in lib/slack-ruby-bot/commands/base.rb - About 1 hr to fix

      Method match_attachments has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

              def match_attachments(data, route, fields_to_scan = nil)
          fields_to_scan ||= %i[pretext text title]
          data.attachments.each do |attachment|
            fields_to_scan.each do |field|
              next unless attachment[field]
      Severity: Minor
      Found in lib/slack-ruby-bot/commands/base.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def parse(actual)
    actual = { message: actual } unless actual.is_a?(Hash)
    attachments = actual[:attachments]
    attachments = [attachments] unless attachments.nil? || attachments.is_a?(Array)
    [actual[:channel] || 'channel', actual[:user] || 'user', actual[:message], attachments]
      Severity: Minor
      Found in lib/slack-ruby-bot/rspec/support/slack-ruby-bot/not_respond.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          def parse(actual)
      actual = { message: actual } unless actual.is_a?(Hash)
      attachments = actual[:attachments]
      attachments = [attachments] unless attachments.nil? || attachments.is_a?(Array)
      [actual[:channel] || 'channel', actual[:user] || 'user', actual[:message], attachments]
      Severity: Major
      Found in lib/slack-ruby-bot/rspec/support/spec_helpers.rb and 2 other locations - About 45 mins to fix
      lib/slack-ruby-bot/rspec/support/slack-ruby-bot/not_respond.rb on lines 19..23
      lib/slack-ruby-bot/rspec/support/slack-ruby-bot/respond_with_error.rb on lines 32..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

        def parse(actual)
    actual = { message: actual } unless actual.is_a?(Hash)
    attachments = actual[:attachments]
    attachments = [attachments] unless attachments.nil? || attachments.is_a?(Array)
    [actual[:channel] || 'channel', actual[:user] || 'user', actual[:message], attachments]
      Severity: Major
      Found in lib/slack-ruby-bot/rspec/support/slack-ruby-bot/respond_with_error.rb and 2 other locations - About 45 mins to fix
      lib/slack-ruby-bot/rspec/support/slack-ruby-bot/not_respond.rb on lines 19..23
      lib/slack-ruby-bot/rspec/support/spec_helpers.rb on lines 7..11

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

        def parse(actual)
    actual = { message: actual } unless actual.is_a?(Hash)
    attachments = actual[:attachments]
    attachments = [attachments] unless attachments.nil? || attachments.is_a?(Array)
    [actual[:channel] || 'channel', actual[:user] || 'user', actual[:message], attachments]
      Severity: Major
      Found in lib/slack-ruby-bot/rspec/support/slack-ruby-bot/not_respond.rb and 2 other locations - About 45 mins to fix
      lib/slack-ruby-bot/rspec/support/slack-ruby-bot/respond_with_error.rb on lines 32..36
      lib/slack-ruby-bot/rspec/support/spec_helpers.rb on lines 7..11

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method send_message_with_gif has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def send_message_with_gif(client, channel, text, keywords, options = {})
      Severity: Minor
      Found in lib/slack-ruby-bot/commands/base.rb - About 35 mins to fix

        Method call_command has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def call_command(client, data, match, block)
          if block
            block.call(client, data, match) if permitted?(client, data, match)
          elsif respond_to?(:call)
            send(:call, client, data, match) if permitted?(client, data, match)
        Severity: Minor
        Found in lib/slack-ruby-bot/commands/base.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def parse(actual)
    actual = { message: actual } unless actual.is_a?(Hash)
    attachments = actual[:attachments]
    attachments = [attachments] unless attachments.nil? || attachments.is_a?(Array)
    [actual[:channel] || 'channel', actual[:user] || 'user', actual[:message], attachments]
        Severity: Minor
        Found in lib/slack-ruby-bot/rspec/support/slack-ruby-bot/respond_with_error.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def call(client, _data)
        return unless client&.team

        new_connected_at = Process.clock_gettime(Process::CLOCK_MONOTONIC)
        log = [
        Severity: Minor
        Found in lib/slack-ruby-bot/hooks/hello.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def parse(actual)
      actual = { message: actual } unless actual.is_a?(Hash)
      attachments = actual[:attachments]
      attachments = [attachments] unless attachments.nil? || attachments.is_a?(Array)
      [actual[:channel] || 'channel', actual[:user] || 'user', actual[:message], attachments]
        Severity: Minor
        Found in lib/slack-ruby-bot/rspec/support/spec_helpers.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language