Sign upLogin

dblock/slack-ruby-client

View on GitHub
Star
bin/commands/calls.rb

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        g.command 'add' do |c|
          c.flag 'external_unique_id', desc: 'An ID supplied by the 3rd-party Call provider. It must be unique across all Calls from that service.'
          c.flag 'join_url', desc: 'The URL required for a client to join the Call.'
          c.flag 'created_by', desc: 'The valid Slack user ID of the user who created this Call. When this method is called with a user token, the created_by field is optional and defaults to the authed user of the token. Otherwise, the field is required.'
          c.flag 'date_start', desc: 'Unix timestamp of the call start time.'
Severity: Major
Found in bin/commands/calls.rb and 3 other locations - About 1 hr to fix
bin/commands/admin_conversations.rb on lines 170..180
bin/commands/conversations.rb on lines 216..226
bin/commands/files.rb on lines 109..119

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status