Sign upLogin

dblock/slack-ruby-client

View on GitHub
Star
bin/commands/users.rb

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        g.command 'conversations' do |c|
          c.flag 'cursor', desc: "Paginate through collections of data by setting the cursor parameter to a next_cursor attribute returned by a previous request's response_metadata. Default value fetches the first 'page' of the collection. See pagination for more detail."
          c.flag 'exclude_archived', desc: 'Set to true to exclude archived channels from the list.'
          c.flag 'limit', desc: "The maximum number of items to return. Fewer than the requested number of items may be returned, even if the end of the list hasn't been reached. Must be an integer with a max value of 999."
          c.flag 'team_id', desc: 'encoded team id to list conversations in, required if org token is used.'
Severity: Major
Found in bin/commands/users.rb and 7 other locations - About 1 hr to fix
bin/commands/chat_scheduledMessages.rb on lines 11..19
bin/commands/conversations.rb on lines 11..19
bin/commands/files_remote.rb on lines 11..19
bin/commands/oauth_v2.rb on lines 11..19
bin/commands/openid_connect.rb on lines 11..19
bin/commands/search.rb on lines 37..45
bin/commands/usergroups.rb on lines 11..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status