Sign upLogin

dblock/slack-ruby-client

View on GitHub
Star
lib/slack/web/api/endpoints/users.rb

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

          def users_conversations(options = {})
            options = options.merge(user: users_id(options)['user']['id']) if options[:user]
            if block_given?
              Pagination::Cursor.new(self, :users_conversations, options).each do |page|
                yield page
Severity: Major
Found in lib/slack/web/api/endpoints/users.rb and 4 other locations - About 35 mins to fix
lib/slack/web/api/endpoints/chat_scheduledMessages.rb on lines 26..33
lib/slack/web/api/endpoints/files_remote.rb on lines 61..68
lib/slack/web/api/endpoints/reactions.rb on lines 63..70
lib/slack/web/api/endpoints/team.rb on lines 45..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

          def users_info(options = {})
            raise ArgumentError, 'Required arguments :user missing' if options[:user].nil?
            options = options.merge(user: users_id(options)['user']['id']) if options[:user]
            post('users.info', options)
Severity: Major
Found in lib/slack/web/api/endpoints/users.rb and 11 other locations - About 25 mins to fix
lib/slack/web/api/endpoints/conversations.rb on lines 52..55
lib/slack/web/api/endpoints/conversations.rb on lines 65..68
lib/slack/web/api/endpoints/conversations.rb on lines 143..146
lib/slack/web/api/endpoints/conversations.rb on lines 178..181
lib/slack/web/api/endpoints/conversations.rb on lines 191..194
lib/slack/web/api/endpoints/conversations.rb on lines 221..224
lib/slack/web/api/endpoints/conversations.rb on lines 417..420
lib/slack/web/api/endpoints/pins.rb on lines 20..23
lib/slack/web/api/endpoints/pins.rb on lines 33..36
lib/slack/web/api/endpoints/pins.rb on lines 48..51
lib/slack/web/api/endpoints/reactions.rb on lines 89..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 30.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status