dblume/pizza-slice

View on GitHub

Showing 7 of 7 total issues

Function drawSlice has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function drawSlice(angle) {
    la = -(Math.PI / 2) - (angle / 2);
    ra = la + angle;
    // Crust
    len = cy;
Severity: Minor
Found in main.js - About 1 hr to fix

    Cyclomatic complexity is too high in function halve_slice_big_angle. (6)
    Open

    def halve_slice_big_angle(angle, radius):
        """ angle must be > 1.8956 (where length is 0.5835 * radius) and < 3.1416 """
        assert(1.8956 <= angle <= math.pi)
        area_of_half_slice = radius * radius * angle / 4.0
    
    
    Severity: Minor
    Found in pizza_slice.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function halve_slice_big_angle has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function halve_slice_big_angle(angle, radius) {
        // angle must be > 1.8956 (where length is 0.5835 * radius) and < 3.1416
        var area_of_half_slice = radius * radius * angle / 4.0;
    
        // if angle = 1.8956, fraction_in_triangles = 0.9999655
    Severity: Minor
    Found in main.js - About 1 hr to fix

      Function onTouchMove has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function onTouchMove(event) {
          var touchX1 = event.touches[0].clientX;
          if (event.targetTouches.length > 1) {
              if (!everMultiTouch) {
                  touches.x2 = event.touches[1].clientX;
      Severity: Minor
      Found in main.js - About 1 hr to fix

        Function halve_slice_big_angle has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        def halve_slice_big_angle(angle, radius):
            """ angle must be > 1.8956 (where length is 0.5835 * radius) and < 3.1416 """
            assert(1.8956 <= angle <= math.pi)
            area_of_half_slice = radius * radius * angle / 4.0
        
        
        Severity: Minor
        Found in pizza_slice.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function halve_slice_big_angle has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function halve_slice_big_angle(angle, radius) {
            // angle must be > 1.8956 (where length is 0.5835 * radius) and < 3.1416
            var area_of_half_slice = radius * radius * angle / 4.0;
        
            // if angle = 1.8956, fraction_in_triangles = 0.9999655
        Severity: Minor
        Found in main.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function onTouchMove has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        function onTouchMove(event) {
            var touchX1 = event.touches[0].clientX;
            if (event.targetTouches.length > 1) {
                if (!everMultiTouch) {
                    touches.x2 = event.touches[1].clientX;
        Severity: Minor
        Found in main.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language