dcadenas/preforker

View on GitHub
lib/preforker.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method reap_all_workers has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def reap_all_workers
    begin
      loop do
        worker_pid, status = Process.waitpid2(-1, Process::WNOHANG)
        break unless worker_pid
Severity: Minor
Found in lib/preforker.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method murder_lazy_workers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def murder_lazy_workers
    @workers.dup.each_pair do |worker_pid, worker|
      stat = worker.tmp.stat
      # skip workers that disable fchmod or have never fchmod-ed
      next if stat.mode == 0100600
Severity: Minor
Found in lib/preforker.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def run(ready_write = nil)
    $stdin.reopen("/dev/null")
    set_stdout_path(@options[:stdout_path])
    set_stderr_path(@options[:stderr_path])

Severity: Minor
Found in lib/preforker.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status