Sign upLogin

decko-commons/decko

View on GitHub
Star
card/lib/card/format/wrapper.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
96%

Assignment Branch Condition size for with_wrapper is too high. [17.38/15]
Open

      def with_wrapper
        if voo.layout.present?
          voo.wrap ||= []
          layout = voo.layout.to_name.key
          # don't wrap twice with modals or overlays
Severity: Minor
Found in card/lib/card/format/wrapper.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

        if wrapper.is_a? String
Severity: Minor
Found in card/lib/card/format/wrapper.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Missing top-level module documentation comment.
Open

    module Wrapper
Severity: Minor
Found in card/lib/card/format/wrapper.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status