decko-commons/decko

View on GitHub
card/lib/card/set/pattern/all.rb

Summary

Maintainability
A
25 mins
Test Coverage
A
94%

Method each_type_assigning_module_key has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def each_type_assigning_module_key
          patterns.each do |p|
            next unless p.assigns_type

            module_key = p.module_key
Severity: Minor
Found in card/lib/card/set/pattern/all.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Do not prefix writer method names with set_.
Invalid

        def set_format_modules klass
Severity: Minor
Found in card/lib/card/set/pattern/all.rb by rubocop

This cop makes sure that accessor methods are named properly.

Example:

# bad
def set_attribute(value)
end

# good
def attribute=(value)
end

# bad
def get_attribute
end

# good
def attribute
end

There are no issues that match your filters.

Category
Status