Sign upLogin

decko-commons/decko

View on GitHub
Star
card/spec/support/helper/card_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage

When using method_missing, define respond_to_missing?.
Open

      def method_missing m, *args, &block
        return super unless Card.rspec_binding

        suppress_name_error do
          method = eval("method(%s)" % m.inspect, Card.rspec_binding)
Severity: Minor
Found in card/spec/support/helper/card_helper.rb by rubocop

This cop checks for the presence of method_missing without also defining respond_to_missing? and falling back on super.

Example:

#bad
def method_missing(name, *args)
  # ...
end

#good
def respond_to_missing?(name, include_private)
  # ...
end

def method_missing(name, *args)
  # ...
  super
end

Missing top-level module documentation comment.
Open

      module ClassMethods
Severity: Minor
Found in card/spec/support/helper/card_helper.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Do not suppress exceptions.
Open

      rescue NameError
Severity: Minor
Found in card/spec/support/helper/card_helper.rb by rubocop

This cop checks for rescue blocks with no body.

Example:

# bad

def some_method
  do_something
rescue
  # do nothing
end

Example:

# bad

begin
  do_something
rescue
  # do nothing
end

Example:

# good

def some_method
  do_something
rescue
  handle_exception
end

Example:

# good

begin
  do_something
rescue
  handle_exception
end

Prefer annotated tokens (like %<foo>s</foo>) over unannotated tokens (like %s).
Open

          method = eval("method(%s)" % m.inspect, Card.rspec_binding)
Severity: Minor
Found in card/spec/support/helper/card_helper.rb by rubocop

Use a consistent style for named format string tokens.

Note: unannotated style cop only works for strings which are passed as arguments to those methods: sprintf, format, %. The reason is that unannotated format is very similar to encoded URLs or Date/Time formatting strings.

Example: EnforcedStyle: annotated (default)

# bad
format('%{greeting}', greeting: 'Hello')
format('%s', 'Hello')

# good
format('%<greeting>s', greeting: 'Hello')</greeting>

Example: EnforcedStyle: template

# bad
format('%<greeting>s', greeting: 'Hello')
format('%s', 'Hello')

# good
format('%{greeting}', greeting: 'Hello')</greeting>

Example: EnforcedStyle: unannotated

# bad
format('%<greeting>s', greeting: 'Hello')
format('%{greeting}', 'Hello')

# good
format('%s', 'Hello')</greeting>

There are no issues that match your filters.

Category
Status