deeem/hexlet-psr-linter

View on GitHub
sniffs/SideEffect.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method defineNode has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function defineNode($node)
    {
        $definitions = [
            function ($node) {
                // for example: include 'file.php';
Severity: Minor
Found in sniffs/SideEffect.php - About 1 hr to fix

    Function defineNode has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private function defineNode($node)
        {
            $definitions = [
                function ($node) {
                    // for example: include 'file.php';
    Severity: Minor
    Found in sniffs/SideEffect.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return $definition;
    Severity: Major
    Found in sniffs/SideEffect.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return self::DECLARATION;
      Severity: Major
      Found in sniffs/SideEffect.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                            return self::DECLARATION;
        Severity: Major
        Found in sniffs/SideEffect.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status