Sign upLogin

deep-web-solutions/wordpress-framework-woocommerce

View on GitHub
Star

Showing 7 of 8 total issues

WC_AbstractValidatedProductSettingsGroupFunctionality has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class WC_AbstractValidatedProductSettingsGroupFunctionality extends AbstractPluginFunctionality implements ValidationServiceAwareInterface {
    // region TRAITS

    use InitializeValidationServiceTrait , ValidationServiceAwareTrait {
        ValidationServiceAwareTrait::get_default_value as protected get_default_value_trait;
Severity: Minor
Found in src/includes/Settings/Functionalities/WC_AbstractValidatedProductSettingsGroupFunctionality.php - About 3 hrs to fix

    Method output_tab_panel has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function output_tab_panel(): void {
        global $thepostid;

        if ( true !== $this->is_supported_product( $thepostid ) ) {
            return;
    Severity: Major
    Found in src/includes/Settings/Functionalities/WC_AbstractValidatedProductSettingsTabFunctionality.php - About 2 hrs to fix

      Function output_tab_panel has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function output_tab_panel(): void {
        global $thepostid;

        if ( true !== $this->is_supported_product( $thepostid ) ) {
            return;
      Severity: Minor
      Found in src/includes/Settings/Functionalities/WC_AbstractValidatedProductSettingsTabFunctionality.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method register_options_group has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function register_options_group( string $group_id, $group_title, $fields, string $page, array $params ): bool {
        if ( \did_action( "woocommerce_sections_$page" ) ) {
            return false;
        }
      Severity: Minor
      Found in src/includes/Settings/WC_SettingsAdapter.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function maybe_get_field_value( $value, string $field_id, int $product_id ) {
        $return = $value;

        if ( \is_null( $return ) ) {
            $field_prefix = Strings::maybe_suffix( $this->get_group_name(), '/' );
        Severity: Minor
        Found in src/includes/Settings/Functionalities/WC_AbstractValidatedProductSettingsGroupFunctionality.php and 1 other location - About 55 mins to fix
        src/includes/Settings/Functionalities/WC_AbstractValidatedProductSettingsGroupFunctionality.php on lines 426..437

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function maybe_get_validated_field_value( $value, string $field_id, int $product_id ) {
        $return = $value;

        if ( \is_null( $return ) ) {
            $field_prefix = Strings::maybe_suffix( $this->get_group_name(), '/' );
        Severity: Minor
        Found in src/includes/Settings/Functionalities/WC_AbstractValidatedProductSettingsGroupFunctionality.php and 1 other location - About 55 mins to fix
        src/includes/Settings/Functionalities/WC_AbstractValidatedProductSettingsGroupFunctionality.php on lines 401..412

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function filter_default_wc_metadata has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function filter_default_wc_metadata( array $meta_data, object $object ): array {
        if ( \is_a( $object, \WC_Product::class ) && true === $this->is_supported_product( $object->get_id() ) ) {
            $existing_meta_keys = \array_flip( \array_column( $meta_data, 'meta_key' ) );

            foreach ( \array_keys( $this->get_group_fields() ) as $field_id ) {
        Severity: Minor
        Found in src/includes/Settings/Functionalities/WC_AbstractValidatedProductSettingsGroupFunctionality.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language