Sign upLogin

deeplearning4j/deeplearning4j

View on GitHub
Star
codegen/onnx-def-gen/onnx_def_gen.py

Summary

Maintainability
C
1 day
Test Coverage

Function convert_attr_type_to_enum has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def convert_attr_type_to_enum(attr_value):
    """
    Pass in an attribute from OpDescriptor and
    get back out the equivalent enum value
    for conversion to an attribute proto.
Severity: Minor
Found in codegen/onnx-def-gen/onnx_def_gen.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create_node_from_schema has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def create_node_from_schema(schema):

    """
    Convert an OpSchema to a NodeProto
    :param schema:  the input OpSchema
Severity: Minor
Found in codegen/onnx-def-gen/onnx_def_gen.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return 4
Severity: Major
Found in codegen/onnx-def-gen/onnx_def_gen.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return 9
    Severity: Major
    Found in codegen/onnx-def-gen/onnx_def_gen.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return 2
      Severity: Major
      Found in codegen/onnx-def-gen/onnx_def_gen.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return 11
        Severity: Major
        Found in codegen/onnx-def-gen/onnx_def_gen.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return 10
          Severity: Major
          Found in codegen/onnx-def-gen/onnx_def_gen.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return 8
            Severity: Major
            Found in codegen/onnx-def-gen/onnx_def_gen.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return 12
              Severity: Major
              Found in codegen/onnx-def-gen/onnx_def_gen.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return 1
                Severity: Major
                Found in codegen/onnx-def-gen/onnx_def_gen.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return 3
                  Severity: Major
                  Found in codegen/onnx-def-gen/onnx_def_gen.py - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            type_attr = onnx.helper.make_attribute(input_arr.name + '-types', [str(data_type).replace('tensor(', '').replace(')', '') for data_type in input_types])
                    Severity: Major
                    Found in codegen/onnx-def-gen/onnx_def_gen.py and 1 other location - About 1 hr to fix
                    codegen/onnx-def-gen/onnx_def_gen.py on lines 111..112

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 48.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                type_attr = onnx.helper.make_attribute(output_arr.name + '-types',
                                                   [str(data_type).replace('tensor(', '').replace(')', '') for data_type
                    Severity: Major
                    Found in codegen/onnx-def-gen/onnx_def_gen.py and 1 other location - About 1 hr to fix
                    codegen/onnx-def-gen/onnx_def_gen.py on lines 101..101

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 48.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status