Sign upLogin

deeplearning4j/deeplearning4j

View on GitHub
Star
codegen/op-codegen/src/main/java/org/nd4j/codegen/cli/CLI.java

Summary

Maintainability
C
1 day
Test Coverage

Method generateNamespaces has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    private void generateNamespaces(NS_PROJECT project, File outputDir, String basePackage) throws IOException {

        List<Namespace> usedNamespaces = new ArrayList<>();

        for(String s : namespaces) {
Severity: Minor
Found in codegen/op-codegen/src/main/java/org/nd4j/codegen/cli/CLI.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method runMain has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public void runMain(String[] args) throws Exception {
        JCommander.newBuilder()
                .addObject(this)
                .build()
                .parse(args);
Severity: Minor
Found in codegen/op-codegen/src/main/java/org/nd4j/codegen/cli/CLI.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generateNamespaces has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void generateNamespaces(NS_PROJECT project, File outputDir, String basePackage) throws IOException {

        List<Namespace> usedNamespaces = new ArrayList<>();

        for(String s : namespaces) {
Severity: Minor
Found in codegen/op-codegen/src/main/java/org/nd4j/codegen/cli/CLI.java - About 1 hr to fix

    Method runMain has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public void runMain(String[] args) throws Exception {
        JCommander.newBuilder()
                .addObject(this)
                .build()
                .parse(args);
    Severity: Minor
    Found in codegen/op-codegen/src/main/java/org/nd4j/codegen/cli/CLI.java - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (StringUtils.isNotEmpty(repoRootDir)) {
            //First: Check root directory.
            File dir = new File(repoRootDir);
            if (!dir.exists() || !dir.isDirectory()) {
                throw new IllegalStateException("Provided root directory does not exist (or not a directory): " + dir.getAbsolutePath());
      Severity: Major
      Found in codegen/op-codegen/src/main/java/org/nd4j/codegen/cli/CLI.java and 1 other location - About 1 hr to fix
      codegen/op-codegen/src/main/java/org/nd4j/codegen/cli/PicoCliCodeGen.java on lines 162..173

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  else {
                ns = Namespace.fromString(s);
                if (ns == null) {
                    log.error("Invalid/unknown SD namespace provided: " + s);
                }
      Severity: Minor
      Found in codegen/op-codegen/src/main/java/org/nd4j/codegen/cli/CLI.java and 1 other location - About 35 mins to fix
      codegen/op-codegen/src/main/java/org/nd4j/codegen/cli/CLI.java on lines 89..97

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (project == NS_PROJECT.ND4J) {
                ns = Namespace.fromString(s);
                if (ns == null) {
                    log.error("Invalid/unknown ND4J namespace provided: " + s);
                }
      Severity: Minor
      Found in codegen/op-codegen/src/main/java/org/nd4j/codegen/cli/CLI.java and 1 other location - About 35 mins to fix
      codegen/op-codegen/src/main/java/org/nd4j/codegen/cli/CLI.java on lines 98..106

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status