Sign upLogin

deeplearning4j/deeplearning4j

View on GitHub
Star
contrib/unified-profiler-analyzer/src/main/java/org/eclipse/deeplearning4j/profiler/unifiedprofiler/analysis/UnifiedProfilerAggregateArrowConverter.java

Summary

Maintainability
C
1 day
Test Coverage

Method splitLogFile has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    private static void splitLogFile(File logFile, double numLinesPerFile) throws IOException {
        Scanner scanner = new Scanner(logFile);
        int count = 0;
        while (scanner.hasNextLine()) {
            scanner.nextLine();
Severity: Minor
Found in contrib/unified-profiler-analyzer/src/main/java/org/eclipse/deeplearning4j/profiler/unifiedprofiler/analysis/UnifiedProfilerAggregateArrowConverter.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method splitLogFile has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static void splitLogFile(File logFile, double numLinesPerFile) throws IOException {
        Scanner scanner = new Scanner(logFile);
        int count = 0;
        while (scanner.hasNextLine()) {
            scanner.nextLine();
Severity: Minor
Found in contrib/unified-profiler-analyzer/src/main/java/org/eclipse/deeplearning4j/profiler/unifiedprofiler/analysis/UnifiedProfilerAggregateArrowConverter.java - About 1 hr to fix

    Method main has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static void main(String... args) throws Exception {
        Schema schema = new Schema.Builder()
                .addColumnLong("eventTimeMs")
                .addColumnString("associatedWorkspace")
                .addColumnLong("workspaceSpilledBytes")
    Severity: Minor
    Found in contrib/unified-profiler-analyzer/src/main/java/org/eclipse/deeplearning4j/profiler/unifiedprofiler/analysis/UnifiedProfilerAggregateArrowConverter.java - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private static void splitLogFile(File logFile, double numLinesPerFile) throws IOException {
        Scanner scanner = new Scanner(logFile);
        int count = 0;
        while (scanner.hasNextLine()) {
            scanner.nextLine();
      Severity: Major
      Found in contrib/unified-profiler-analyzer/src/main/java/org/eclipse/deeplearning4j/profiler/unifiedprofiler/analysis/UnifiedProfilerAggregateArrowConverter.java and 1 other location - About 5 hrs to fix
      contrib/unified-profiler-analyzer/src/main/java/org/eclipse/deeplearning4j/profiler/unifiedprofiler/analysis/UnifiedProfilerArrowConverter.java on lines 101..149

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 331.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for(File inputFile : inputFiles) {
            FileSplit inputCSv = new FileSplit(inputFile);
            ArrowRecordWriter arrowRecordWriter = new ArrowRecordWriter(schema);
            File outputFile = new File("arrow-output/",inputFile.getName() + ".arrow");
            outputFile.createNewFile();
      Severity: Major
      Found in contrib/unified-profiler-analyzer/src/main/java/org/eclipse/deeplearning4j/profiler/unifiedprofiler/analysis/UnifiedProfilerAggregateArrowConverter.java and 1 other location - About 1 hr to fix
      contrib/unified-profiler-analyzer/src/main/java/org/eclipse/deeplearning4j/profiler/unifiedprofiler/analysis/UnifiedProfilerArrowConverter.java on lines 78..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              Schema schema = new Schema.Builder()
                .addColumnLong("eventTimeMs")
                .addColumnString("associatedWorkspace")
                .addColumnLong("workspaceSpilledBytes")
                .addColumnLong("workspacePinnedBytes")
      Severity: Minor
      Found in contrib/unified-profiler-analyzer/src/main/java/org/eclipse/deeplearning4j/profiler/unifiedprofiler/analysis/UnifiedProfilerAggregateArrowConverter.java and 1 other location - About 50 mins to fix
      contrib/unified-profiler-analyzer/src/main/java/org/eclipse/deeplearning4j/profiler/unifiedprofiler/analysis/UnifiedProfilerAggregateLogAnalyzer.java on lines 95..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status