deeplearning4j/deeplearning4j

View on GitHub
deeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/util/CrashReportingUtil.java

Summary

Maintainability
F
5 days
Test Coverage

File CrashReportingUtil.java has 518 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 *  ******************************************************************************
 *  *
 *  *
 *  * This program and the accompanying materials are made available under the

    Method generateMemoryStatus has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
    Open

        public static String generateMemoryStatus(Model net, int minibatch, InputType... inputTypes){
            MultiLayerNetwork mln = null;
            ComputationGraph cg = null;
            boolean isMLN;
            if(net instanceof MultiLayerNetwork){

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method generateMemoryStatus has 143 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static String generateMemoryStatus(Model net, int minibatch, InputType... inputTypes){
            MultiLayerNetwork mln = null;
            ComputationGraph cg = null;
            boolean isMLN;
            if(net instanceof MultiLayerNetwork){

      Method genericMemoryStatus has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static StringBuilder genericMemoryStatus(){
      
              StringBuilder sb = new StringBuilder();
      
              sb.append("========== Memory Information ==========\n");

        Method appendActivationShapes has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private static void appendActivationShapes(ComputationGraph net, StringBuilder sb, int bytesPerElement){
                INDArray[] input = net.getInputs();
                if(input == null){
                    return;
                }

          Method appendActivationShapes has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              private static void appendActivationShapes(ComputationGraph net, StringBuilder sb, int bytesPerElement){
                  INDArray[] input = net.getInputs();
                  if(input == null){
                      return;
                  }

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method appendActivationShapes has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private static void appendActivationShapes(MultiLayerNetwork net, InputType inputType, int minibatch, StringBuilder sb, int bytesPerElement){
                  INDArray input = net.getInput();
                  if(input == null && inputType == null){
                      return;
                  }

            Method appendHelperInformation has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                private static void appendHelperInformation(StringBuilder sb, Layer[] layers){
                    sb.append("\n----- Layer Helpers - Memory Use -----\n");
            
                    int helperCount = 0;
                    long helperWithMemCount = 0L;

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method appendActivationShapes has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                private static void appendActivationShapes(MultiLayerNetwork net, InputType inputType, int minibatch, StringBuilder sb, int bytesPerElement){
                    INDArray input = net.getInput();
                    if(input == null && inputType == null){
                        return;
                    }

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method appendHelperInformation has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private static void appendHelperInformation(StringBuilder sb, Layer[] layers){
                    sb.append("\n----- Layer Helpers - Memory Use -----\n");
            
                    int helperCount = 0;
                    long helperWithMemCount = 0L;

              Method writeMemoryCrashDump has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static void writeMemoryCrashDump(@NonNull Model net, @NonNull Throwable e){
                      if(!crashDumpsEnabled){
                          return;
                      }
              
              

                Method genericMemoryStatus has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    private static StringBuilder genericMemoryStatus(){
                
                        StringBuilder sb = new StringBuilder();
                
                        sb.append("========== Memory Information ==========\n");

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method appendActivationShapes has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    private static void appendActivationShapes(MultiLayerNetwork net, InputType inputType, int minibatch, StringBuilder sb, int bytesPerElement){

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if(allWs != null && allWs.size() > 0) {
                              sb.append("Current thread workspaces:\n");
                              //Name, open, size, currently allocated
                              String wsFormat = "  %-26s%-12s%-30s%-20s";
                              sb.append(String.format(wsFormat, "Name", "State", "Size", "# Cycles")).append("\n");
                  nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/systeminfo/SystemInfo.java on lines 297..310

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 134.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      private static String fBytes(long bytes){
                          String s = BinaryByteUnit.format(bytes, "#.00");
                          String format = "%10s";
                          s = String.format(format, s);
                          if(bytes >= 1024){
                  nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/systeminfo/SystemInfo.java on lines 71..79

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 70.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          sb.append(fBytes("JVM Memory: XMX", xmx))
                                  .append(fBytes("JVM Memory: current", jvmTotal))
                                  .append(fBytes("JavaCPP Memory: Max Bytes", javacppMaxBytes))
                                  .append(fBytes("JavaCPP Memory: Max Physical", javacppMaxPhys))
                                  .append(fBytes("JavaCPP Memory: Current Bytes", javacppCurrBytes))
                  nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/systeminfo/SystemInfo.java on lines 277..282

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              if(cg.getConfiguration().getBackpropType() == BackpropType.TruncatedBPTT){
                                  sb.append(f("TBPTT Length", cg.getConfiguration().getTbpttFwdLength() + "/" + cg.getConfiguration().getTbpttBackLength()));
                              }
                  deeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/util/CrashReportingUtil.java on lines 314..316

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 44.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              if(mln.getLayerWiseConfigurations().getBackpropType() == BackpropType.TruncatedBPTT){
                                  sb.append(f("TBPTT Length", mln.getLayerWiseConfigurations().getTbpttFwdLength() + "/" + mln.getLayerWiseConfigurations().getTbpttBackLength()));
                              }
                  deeplearning4j/deeplearning4j-nn/src/main/java/org/deeplearning4j/util/CrashReportingUtil.java on lines 324..326

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 44.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status