Sign upLogin

deeplearning4j/deeplearning4j

View on GitHub
Star
nd4j/nd4j-common/src/main/java/org/nd4j/common/collection/CompactHeapStringList.java

Summary

Maintainability
C
1 day
Test Coverage

CompactHeapStringList has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

public class CompactHeapStringList implements List<String> {
    public static final int DEFAULT_REALLOCATION_BLOCK_SIZE_BYTES = 8 * 1024 * 1024; //8MB
    public static final int DEFAULT_INTEGER_REALLOCATION_BLOCK_SIZE_BYTES = 1024 * 1024; //1MB - 262144 ints, 131k entries

    private final int reallocationBlockSizeBytes;
Severity: Minor
Found in nd4j/nd4j-common/src/main/java/org/nd4j/common/collection/CompactHeapStringList.java - About 2 hrs to fix

    File CompactHeapStringList.java has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 *  ******************************************************************************
 *  *
 *  *
 *  * This program and the accompanying materials are made available under the
    Severity: Minor
    Found in nd4j/nd4j-common/src/main/java/org/nd4j/common/collection/CompactHeapStringList.java - About 2 hrs to fix

      Method equals has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public boolean equals(Object o) {
        if (o == this)
            return true;
        if (!(o instanceof List))
      Severity: Minor
      Found in nd4j/nd4j-common/src/main/java/org/nd4j/common/collection/CompactHeapStringList.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method indexOf has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public int indexOf(Object o) {
        if (!(o instanceof String)) {
            return -1;
        }
      Severity: Minor
      Found in nd4j/nd4j-common/src/main/java/org/nd4j/common/collection/CompactHeapStringList.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method lastIndexOf has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public int lastIndexOf(Object o) {
        if (!(o instanceof String)) {
            return -1;
        }
      Severity: Minor
      Found in nd4j/nd4j-common/src/main/java/org/nd4j/common/collection/CompactHeapStringList.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method add has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public boolean add(String s) {
        int length = s.length();
        //3 possibilities:
        //(a) doesn't fit in char[]
      Severity: Minor
      Found in nd4j/nd4j-common/src/main/java/org/nd4j/common/collection/CompactHeapStringList.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (int i = 0; i < usedCount; i++) {
            if (offsetAndLength[2 * i + 1] != ch.length) {
                //Can't be this one: lengths differ
                continue;
            }
      Severity: Major
      Found in nd4j/nd4j-common/src/main/java/org/nd4j/common/collection/CompactHeapStringList.java and 1 other location - About 1 hr to fix
      nd4j/nd4j-common/src/main/java/org/nd4j/common/collection/CompactHeapStringList.java on lines 240..257

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              for (int i = usedCount - 1; i >= 0; i--) {
            if (offsetAndLength[2 * i + 1] != ch.length) {
                //Can't be this one: lengths differ
                continue;
            }
      Severity: Major
      Found in nd4j/nd4j-common/src/main/java/org/nd4j/common/collection/CompactHeapStringList.java and 1 other location - About 1 hr to fix
      nd4j/nd4j-common/src/main/java/org/nd4j/common/collection/CompactHeapStringList.java on lines 208..225

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status