Sign upLogin

deepsweet/baggage-loader

View on GitHub
Star

Showing 6 of 6 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (sourceMap) {
            var currentRequest = loaderUtils.getCurrentRequest(this);
            var SourceNode = SourceMap.SourceNode;
            var SourceMapConsumer = SourceMap.SourceMapConsumer;
            var sourceMapConsumer = new SourceMapConsumer(sourceMap);
Severity: Major
Found in compat/legacy-loader.js and 1 other location - About 5 hrs to fix
index.js on lines 90..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (sourceMap) {
                var currentRequest = loaderUtils.getCurrentRequest(this);
                var SourceNode = SourceMap.SourceNode;
                var SourceMapConsumer = SourceMap.SourceMapConsumer;
                var sourceMapConsumer = new SourceMapConsumer(sourceMap);
Severity: Major
Found in index.js and 1 other location - About 5 hrs to fix
compat/legacy-loader.js on lines 71..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(source, sourceMap) {
    // parseQuery will always give us an object, for back-compat we
    // want to know if we're working with JSON query or query string
    if (!util.isJSONString(this.query.replace('?', ''))) {
        return legacyLoader.call(this, source, sourceMap);
Severity: Major
Found in index.js - About 2 hrs to fix

    Function exports has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(source, sourceMap) {
    var query = loaderUtils.parseQuery(this.query);

    // /foo/bar/file.js
    var srcFilepath = this.resourcePath;
    Severity: Minor
    Found in compat/legacy-loader.js - About 1 hr to fix

      Function exports has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function(source, sourceMap) {
    // parseQuery will always give us an object, for back-compat we
    // want to know if we're working with JSON query or query string
    if (!util.isJSONString(this.query.replace('?', ''))) {
        return legacyLoader.call(this, source, sourceMap);
      Severity: Minor
      Found in index.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return source;
      Severity: Major
      Found in index.js - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language