Sign upLogin

degzcs/paperclip-googledrive

View on GitHub
Star

Showing 3 of 3 total issues

Method url has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def url(*args)
        if present?
          style = args.first.is_a?(Symbol) ? args.first : default_style
          options = args.last.is_a?(Hash) ? args.last : {}
          if style == :custom_thumb && is_valid_for_custom_thumb?
Severity: Minor
Found in lib/paperclip/storage/google_drive.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method extended has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        def extended(base)
          check_gem_is_installed
          base.instance_eval do
            @google_drive_client_secret_path = @options[:google_drive_client_secret_path]
            @google_drive_options = @options[:google_drive_options] || { application_name: 'test-app' }
Severity: Minor
Found in lib/paperclip/storage/google_drive.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def initialize(config_path)
        @config_path = config_path
        if ::File.exist?(config_path)
          JSON.parse(::File.read(config_path)).each do |key, value|
            instance_variable_set("@#{key}", value) if FIELDS.include?(key)
Severity: Minor
Found in lib/paperclip/google_drive/config.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language