Sign upLogin

delihiros/futhon

View on GitHub
Star

Showing 37 of 37 total issues

Function eval_list has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
Open

    def eval_list(self, expr, env):
        if len(expr) == 0:
            return expr
        head = expr[0]
        if datatypes.isSymbol(head):
Severity: Minor
Found in src/evaluator.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

class Symbol(FuthonObject):

    def __init__(self, name):
        self.name = name
Severity: Major
Found in src/datatypes.py and 1 other location - About 5 hrs to fix
src/datatypes.py on lines 58..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

class Keyword(FuthonObject):

    def __init__(self, name):
        self.name = name
Severity: Major
Found in src/datatypes.py and 1 other location - About 5 hrs to fix
src/datatypes.py on lines 22..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function wait_or_run has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def wait_or_run(self, s):
        pairs = {
            ']': '[', '}': '{', ')': '('
        }
        self.lines += s
Severity: Minor
Found in src/repl.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _symbol has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def _symbol(self, node):
        itm = node.tail[0]
        if itm == 'nil' or itm == 'None':
            return None
        elif itm == 'true' or itm == 'True':
Severity: Minor
Found in src/futhon_parser.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function eval has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def eval(self, expr, env):
        if not datatypes.isFuthonObj(expr):
            if isinstance(expr, list):
                return self.eval_list(expr, env)
            return expr
Severity: Minor
Found in src/evaluator.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                return datatypes.Lambda(expr[1], expr[2], copy.copy(env))
Severity: Major
Found in src/evaluator.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                        return None
    Severity: Major
    Found in src/evaluator.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                              return v
      Severity: Major
      Found in src/evaluator.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return len(expr[1])
        Severity: Major
        Found in src/evaluator.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                              return f(*args)
          Severity: Major
          Found in src/evaluator.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return self.apply_function(head, args, env)
            Severity: Major
            Found in src/evaluator.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return None
              Severity: Major
              Found in src/evaluator.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return dynamic.import_module(expr[1].name)
                Severity: Major
                Found in src/evaluator.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                      return dynamic.attribute_or_call(instance, method_name, args)
                  Severity: Major
                  Found in src/evaluator.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return None
                    Severity: Major
                    Found in src/evaluator.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return head.get(self.eval(expr[1], env))
                      Severity: Major
                      Found in src/evaluator.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                            return head
                        Severity: Major
                        Found in src/evaluator.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                          return expr[1]
                          Severity: Major
                          Found in src/evaluator.py - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                            return v
                            Severity: Major
                            Found in src/evaluator.py - About 30 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language