Sign upLogin

dennis-tra/pcp

View on GitHub
Star

Showing 24 of 24 total issues

Method PakeProtocol.ReceiveVerifyProof has 5 return statements (exceeds 4 allowed).
Open

func (p *PakeProtocol) ReceiveVerifyProof(s network.Stream, key []byte) error {
    response, err := p.node.ReadBytes(s)
    if err != nil {
        return err
    }
Severity: Major
Found in pkg/node/pake.go - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (n *Node) StopAdvertising() {
    var wg sync.WaitGroup
    for _, advertiser := range n.advertisers {
        wg.Add(1)
        go func(a Advertiser) {
    Severity: Minor
    Found in pkg/send/node.go and 1 other location - About 35 mins to fix
    pkg/receive/node.go on lines 114..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method Node.Transfer has 5 return statements (exceeds 4 allowed).
    Open

    func (n *Node) Transfer(peerID peer.ID) error {
    filename := path.Base(n.filepath)
    size, err := totalSize(n.filepath)
    if err != nil {
        return err
    Severity: Major
    Found in pkg/send/node.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (n *Node) StopDiscovering() {
    var wg sync.WaitGroup
    for _, discoverer := range n.discoverers {
        wg.Add(1)
        go func(d Discoverer) {
      Severity: Minor
      Found in pkg/receive/node.go and 1 other location - About 35 mins to fix
      pkg/send/node.go on lines 106..116

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 105.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language