Sign upLogin

dennis-tra/pcp

View on GitHub
Star
pkg/node/transfer.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method TransferProtocol.Transfer has 65 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (t *TransferProtocol) Transfer(ctx context.Context, peerID peer.ID, basePath string) error {
    // Open a new stream to our peer.
    s, err := t.node.NewStream(ctx, peerID, ProtocolTransfer)
    if err != nil {
        return err
Severity: Minor
Found in pkg/node/transfer.go - About 1 hr to fix

    Method TransferProtocol.Transfer has 16 return statements (exceeds 4 allowed).
    Open

    func (t *TransferProtocol) Transfer(ctx context.Context, peerID peer.ID, basePath string) error {
    // Open a new stream to our peer.
    s, err := t.node.NewStream(ctx, peerID, ProtocolTransfer)
    if err != nil {
        return err
    Severity: Major
    Found in pkg/node/transfer.go - About 1 hr to fix

      Method TransferProtocol.onTransfer has 6 return statements (exceeds 4 allowed).
      Open

      func (t *TransferProtocol) onTransfer(s network.Stream) {
    defer t.th.Done()
    defer t.node.ResetOnShutdown(s)()

    // Get PAKE session key for stream decryption
      Severity: Major
      Found in pkg/node/transfer.go - About 40 mins to fix

        Method TransferProtocol.Transfer has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

        func (t *TransferProtocol) Transfer(ctx context.Context, peerID peer.ID, basePath string) error {
    // Open a new stream to our peer.
    s, err := t.node.NewStream(ctx, peerID, ProtocolTransfer)
    if err != nil {
        return err
        Severity: Minor
        Found in pkg/node/transfer.go - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status