Sign upLogin

denny/ShinyCMS-ruby

View on GitHub
Star

Showing 659 of 660 total issues

Avoid too many return statements within this method.
Confirmed

      return false unless user.admin?
Severity: Major
Found in plugins/ShinyCMS/app/models/shinycms/feature_flag.rb - About 30 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def skip_callbacks_on_some_models
      ShinyNewsletters::Template.skip_callback :create, :after, :add_elements
      ShinyNewsletters::Edition.skip_callback  :create, :after, :add_elements
      ShinyPages::Template.skip_callback       :create, :after, :add_elements
      ShinyPages::Page.skip_callback           :create, :after, :add_elements
    Severity: Minor
    Found in plugins/ShinyCMS/lib/tasks/support/demo_site_task.rb and 1 other location - About 30 mins to fix
    plugins/ShinyCMS/lib/tasks/support/demo_site_task.rb on lines 120..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def set_callbacks_on_some_models
      ShinyNewsletters::Template.set_callback :create, :after, :add_elements
      ShinyNewsletters::Edition.set_callback  :create, :after, :add_elements
      ShinyPages::Template.set_callback       :create, :after, :add_elements
      ShinyPages::Page.set_callback           :create, :after, :add_elements
    Severity: Minor
    Found in plugins/ShinyCMS/lib/tasks/support/demo_site_task.rb and 1 other location - About 30 mins to fix
    plugins/ShinyCMS/lib/tasks/support/demo_site_task.rb on lines 112..118

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      class SubscriptionPolicy
    attr_reader :this_user, :record

    def initialize( this_user, record )
      @this_user = this_user
    Severity: Minor
    Found in plugins/ShinyLists/app/policies/shiny_lists/subscription_policy.rb and 1 other location - About 25 mins to fix
    plugins/ShinyAccess/app/policies/shiny_access/membership_policy.rb on lines 11..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      class MembershipPolicy
    attr_reader :this_user, :record

    def initialize( this_user, record )
      @this_user = this_user
    Severity: Minor
    Found in plugins/ShinyAccess/app/policies/shiny_access/membership_policy.rb and 1 other location - About 25 mins to fix
    plugins/ShinyLists/app/policies/shiny_lists/subscription_policy.rb on lines 11..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def configure_password( admin, account_details )
    while admin.errors.messages.key? :password
      display_errors( 'password', admin.errors[ :password ] ) if account_details[ :password ].present?

      account_details[ :password ] = prompt_for_input( 'password' )
    Severity: Minor
    Found in plugins/ShinyCMS/lib/tasks/support/admin_user_task.rb and 1 other location - About 25 mins to fix
    plugins/ShinyCMS/lib/tasks/support/admin_user_task.rb on lines 12..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      def configure_username( admin, account_details )
    while admin.errors.messages.key? :username
      display_errors( 'username', admin.errors[ :username ] ) if account_details[ :username ].present?

      account_details[ :username ] = prompt_for_input( 'username' )
    Severity: Minor
    Found in plugins/ShinyCMS/lib/tasks/support/admin_user_task.rb and 1 other location - About 25 mins to fix
    plugins/ShinyCMS/lib/tasks/support/admin_user_task.rb on lines 23..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def update_settings( params )
      flags = initialise_flags
      params&.each_key do |key|
        next unless /value_(?<id>\d+)/ =~ key
    Severity: Minor
    Found in plugins/ShinyCMS/app/controllers/shinycms/site_settings_controller.rb and 1 other location - About 25 mins to fix
    plugins/ShinyCMS/app/controllers/shinycms/admin/site_settings_controller.rb on lines 36..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method update_value has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Confirmed

        def update_value( id, params )
      setting = Setting.find( id )

      return false if setting.level == 'site'
      return false if setting.level == 'admin' && current_user_is_not_admin?
    Severity: Minor
    Found in plugins/ShinyCMS/app/controllers/shinycms/site_settings_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method enabled? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Confirmed

        def self.enabled?( name, user = nil )
      feature = find_by( name: name.to_s )

      return false if feature.blank?
      return true  if feature.enabled?
    Severity: Minor
    Found in plugins/ShinyCMS/app/models/shinycms/feature_flag.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method seed_setting has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def seed_setting( name:, value: '', description: nil, level: 'site', locked: false )
      setting = ShinyCMS::Setting.find_or_create_by!( name: name.to_s )
      setting.unlock

      setting.update!( description: description ) if description.present?
    Severity: Minor
    Found in plugins/ShinyCMS/app/public/lib/shinycms/seeder.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method perform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Confirmed

        def perform( send )
      return unless send.sendable?

      send.mark_as_sending
    Severity: Minor
    Found in plugins/ShinyNewsletters/app/jobs/shiny_newsletters/send_to_list_job.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def update_settings( params )
      flags = initialise_flags
      params&.each_key do |key|
        next unless /value_(?<id>\d+)/ =~ key
    Severity: Minor
    Found in plugins/ShinyCMS/app/controllers/shinycms/admin/site_settings_controller.rb and 1 other location - About 25 mins to fix
    plugins/ShinyCMS/app/controllers/shinycms/site_settings_controller.rb on lines 37..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def create
      @group = Group.new( strong_params )
      authorize @group

      if @group.save
    Severity: Minor
    Found in plugins/ShinyAccess/app/controllers/shiny_access/admin/groups_controller.rb and 1 other location - About 25 mins to fix
    plugins/ShinyLists/app/controllers/shiny_lists/admin/lists_controller.rb on lines 36..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def update
      authorize @page

      if sort_elements && @page.update( strong_params )
        redirect_to shiny_pages.edit_page_path( @page ), notice: t( '.success' )
    Severity: Minor
    Found in plugins/ShinyPages/app/controllers/shiny_pages/admin/pages_controller.rb and 1 other location - About 25 mins to fix
    plugins/ShinyNewsletters/app/controllers/shiny_newsletters/admin/editions_controller.rb on lines 57..65

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def create
      @list = List.new( list_params )
      authorize @list

      if @list.save
    Severity: Minor
    Found in plugins/ShinyLists/app/controllers/shiny_lists/admin/lists_controller.rb and 1 other location - About 25 mins to fix
    plugins/ShinyAccess/app/controllers/shiny_access/admin/groups_controller.rb on lines 37..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def update
      authorize @edition

      if sort_elements && @edition.update( strong_params )
        redirect_to shiny_newsletters.edit_edition_path( @edition ), notice: t( '.success' )
    Severity: Minor
    Found in plugins/ShinyNewsletters/app/controllers/shiny_newsletters/admin/editions_controller.rb and 1 other location - About 25 mins to fix
    plugins/ShinyPages/app/controllers/shiny_pages/admin/pages_controller.rb on lines 64..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def update
      authorize @template

      if sort_elements && @template.update( strong_params )
        redirect_to shiny_pages.edit_template_path( @template ), notice: t( '.success' )
    Severity: Minor
    Found in plugins/ShinyPages/app/controllers/shiny_pages/admin/templates_controller.rb and 1 other location - About 20 mins to fix
    plugins/ShinyNewsletters/app/controllers/shiny_newsletters/admin/templates_controller.rb on lines 57..65

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def update
      authorize @template

      if sort_elements && @template.update( strong_params )
        redirect_to shiny_newsletters.edit_template_path( @template ), notice: t( '.success' )
    Severity: Minor
    Found in plugins/ShinyNewsletters/app/controllers/shiny_newsletters/admin/templates_controller.rb and 1 other location - About 20 mins to fix
    plugins/ShinyPages/app/controllers/shiny_pages/admin/templates_controller.rb on lines 59..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def update
      authorize @group

      if @group.update( strong_params )
        redirect_to edit_group_path( @group ), notice: t( '.success' )
    Severity: Minor
    Found in plugins/ShinyAccess/app/controllers/shiny_access/admin/groups_controller.rb and 1 other location - About 15 mins to fix
    plugins/ShinyCMS/app/controllers/shinycms/admin/consent_versions_controller.rb on lines 57..65

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language