Sign upLogin

denpamusic/laravel-bitcoinrpc

View on GitHub
Star
src/LaravelClient.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid using static access to class '\Illuminate\Support\Arr' in method '__construct'.
Wontfix

                Arr::pull($config, 'zeromq'),
Severity: Minor
Found in src/LaravelClient.php by phpmd

Since: PHPMD 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example:

class Foo
  {
      public function bar()
      {
          Bar::baz();
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

Avoid using short method names like LaravelClient::on(). The configured minimum method name length is 3.
Wontfix

    public function on(string $topic, callable $callback): void
    {
        if (is_null($this->zeromq)) {
            throw new BadMethodCallException(
                'ZeroMQ support is not available, because '.
Severity: Minor
Found in src/LaravelClient.php by phpmd

Since: PHPMD 0.2

Detects when very short method names are used.

Example:

class ShortMethod {
      public function a( $index ) { // Violation
      }
  }

Source: http://phpmd.org/rules/naming.txt

There are no issues that match your filters.

Category
Status