deparkes/OOMMFTools

View on GitHub
oommftools/core/odtchomp.py

Summary

Maintainability
C
1 day
Test Coverage

Function chomp has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

def chomp(odt, parent=None):
    """
    """
    retHeaders = []
    retDict = {}
Severity: Minor
Found in oommftools/core/odtchomp.py - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function namepolish has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

def namepolish(name, uniquenessCheck):
    """Uniquely identify quantity fields.

    This is pretty ugly, but the key point is this: it filters
    down to the minimum amount of information necessary to uniquely identify a quantity
Severity: Minor
Found in oommftools/core/odtchomp.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if grab:
                        log("Indexing %s at point %d" % (grab, len(retHeaders)))
                        retHeaders.append(grab)
                        if not grab in retDict:
                            log("Identifying new header: %s" % grab)
Severity: Major
Found in oommftools/core/odtchomp.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if line[0] == "{":
                            #Group match!
                            grab, line = line.split("}", 1)
                            line = line.strip() #Must clear trailing spaces
                            grab = grab.strip("{}")
    Severity: Major
    Found in oommftools/core/odtchomp.py - About 45 mins to fix

      Function write has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def write(filename, interpreter, delim, fields):
          """
          """
          print("Write out to:", filename)
          refdelim = delim
      Severity: Minor
      Found in oommftools/core/odtchomp.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status