department-of-veterans-affairs/vets-website

View on GitHub

Showing 12,848 of 12,848 total issues

Function CrisisLineConnectButton has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const CrisisLineConnectButton = () => {
  const [lastFocusableElement, setLastFocusableElement] = useState(null);
  const [crisisModalOpened, setCrisisModalOpened] = useState(false);

  useEffect(

    Function handleSearch has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const handleSearch = () => {
        setFiltersCleared(false);
        if (filterBoxRef.current.checkFormValidity()) return;
    
        let relativeToDate;

      Function PreferredDatePage has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export default function PreferredDatePage() {
        const pageTitle = useSelector(state => getPageTitle(state, pageKey));
      
        const dispatch = useDispatch();
        const { schema, data, pageChangeInProgress } = useSelector(

        Function PreferredDatesSection has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export default function PreferredDatesSection(props) {
          const history = useHistory();
          const { home, ccRequestDateTime, requestDateTime } = useSelector(
            getNewAppointmentFlow,
          );

          Function uiSchema has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function uiSchema(
            addressTitle = applicantContactInfoAddressTitle,
            contactInfoSubheader = applicantContactInfoSubheader,
            contactInfoDescription = applicantContactInfoDescription,
          ) {

            Function locationUiSchema has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const locationUiSchema = uiRequiredCallback => {
              return {
                isOutsideUs: {
                  'ui:title': 'This happened outside of the U.S.',
                },

              Function debtsReducer has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export const debtsReducer = (state = initialState, action) => {
                switch (action.type) {
                  case DEBTS_FETCH_INITIATED || COPAYS_FETCH_INITIATED:
                    return {
                      ...state,
              Severity: Minor
              Found in src/applications/personalization/dashboard/reducers/debts.js - About 1 hr to fix

                Function refreshReducer has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                export const refreshReducer = (state = initialState, action) => {
                  switch (action.type) {
                    case Actions.Refresh.SET_INITIAL_FHIR_LOAD: {
                      return {
                        ...state,
                Severity: Minor
                Found in src/applications/mhv-medical-records/reducers/refresh.js - About 1 hr to fix

                  Function ChemHemResults has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  const ChemHemResults = props => {
                    const { results } = props;
                  
                    return (
                      <ul className="result-cards">

                    Function PhrRefresh has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    const PhrRefresh = () => {
                      const dispatch = useDispatch();
                      const refresh = useSelector(state => state.mr.refresh);
                      const [endPollingDate, setEndPollingDate] = useState(null);
                    
                    

                      Function prefillContactInformation has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        const prefillContactInformation = data => {
                          const newData = _.omit(['contactInformation', 'avaProfile'], data);
                          const { contactInformation, avaProfile } = data;
                      
                          if (contactInformation) {
                      Severity: Minor
                      Found in src/applications/representative-appoint/prefill-transformer.js - About 1 hr to fix

                        Function PrintOnlyPage has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        const PrintOnlyPage = props => {
                          const { children, title, preface, subtitle, hasError } = props;
                          return (
                            <div className="print-only landing-page">
                              <div
                        Severity: Minor
                        Found in src/applications/mhv-medications/containers/PrintOnlyPage.jsx - About 1 hr to fix

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                                  veteranBenefitSelection: {
                                    path: 'veteran-benefit-selection',
                                    depends: formData => shouldSeeVeteranBenefitSelection({ formData }),
                                    title: formData => benefitSelectionChapterTitle({ formData }),
                                    uiSchema: veteranBenefitSelection.uiSchema,
                          Severity: Major
                          Found in src/applications/simple-forms/21-0966/config/form.js and 4 other locations - About 1 hr to fix
                          src/applications/simple-forms/21-0966/config/form.js on lines 191..197
                          src/applications/simple-forms/21-0966/config/form.js on lines 198..204
                          src/applications/simple-forms/21-0966/config/form.js on lines 205..212
                          src/applications/simple-forms/21-0966/config/form.js on lines 219..229

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 67.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                                  thirdPartySurvivingDependentBenefitSelection: {
                                    path: 'third-party-surviving-dependent-benefit-selection',
                                    depends: formData =>
                                      preparerIsThirdPartyToASurvivingDependent({ formData }),
                                    title: formData => benefitSelectionChapterTitle({ formData }),
                          Severity: Major
                          Found in src/applications/simple-forms/21-0966/config/form.js and 4 other locations - About 1 hr to fix
                          src/applications/simple-forms/21-0966/config/form.js on lines 156..162
                          src/applications/simple-forms/21-0966/config/form.js on lines 191..197
                          src/applications/simple-forms/21-0966/config/form.js on lines 198..204
                          src/applications/simple-forms/21-0966/config/form.js on lines 219..229

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 67.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                                  thirdPartyVeteranBenefitSelection: {
                                    path: 'third-party-veteran-benefit-selection',
                                    depends: formData => preparerIsThirdPartyToTheVeteran({ formData }),
                                    title: formData => benefitSelectionChapterTitle({ formData }),
                                    uiSchema: thirdPartyVeteranBenefitSelection.uiSchema,
                          Severity: Major
                          Found in src/applications/simple-forms/21-0966/config/form.js and 4 other locations - About 1 hr to fix
                          src/applications/simple-forms/21-0966/config/form.js on lines 156..162
                          src/applications/simple-forms/21-0966/config/form.js on lines 198..204
                          src/applications/simple-forms/21-0966/config/form.js on lines 205..212
                          src/applications/simple-forms/21-0966/config/form.js on lines 219..229

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 67.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                                  survivingDependentBenefitSelection: {
                                    path: 'surviving-dependent-benefit-selection',
                                    depends: formData => preparerIsSurvivingDependent({ formData }),
                                    title: formData => benefitSelectionChapterTitle({ formData }),
                                    uiSchema: survivingDependentBenefitSelection.uiSchema,
                          Severity: Major
                          Found in src/applications/simple-forms/21-0966/config/form.js and 4 other locations - About 1 hr to fix
                          src/applications/simple-forms/21-0966/config/form.js on lines 156..162
                          src/applications/simple-forms/21-0966/config/form.js on lines 191..197
                          src/applications/simple-forms/21-0966/config/form.js on lines 205..212
                          src/applications/simple-forms/21-0966/config/form.js on lines 219..229

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 67.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                                  survivingDependentPersonalInformation: {
                                    path: 'surviving-dependent-personal-information',
                                    depends: formData =>
                                      preparerIsSurvivingDependentOrThirdPartyToSurvivingDependent({
                                        formData,
                          Severity: Major
                          Found in src/applications/simple-forms/21-0966/config/form.js and 4 other locations - About 1 hr to fix
                          src/applications/simple-forms/21-0966/config/form.js on lines 156..162
                          src/applications/simple-forms/21-0966/config/form.js on lines 191..197
                          src/applications/simple-forms/21-0966/config/form.js on lines 198..204
                          src/applications/simple-forms/21-0966/config/form.js on lines 205..212

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 67.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                            if (grantedListItems.length) {
                              grantedSection = (
                                <div className="granted-section">
                                  <h4 className="vads-u-font-size--h5">Granted</h4>
                                  <ul>{grantedListItems}</ul>
                          src/applications/claims-status/components/appeals-v2/Issues.jsx on lines 31..38
                          src/applications/claims-status/components/appeals-v2/Issues.jsx on lines 51..58
                          src/applications/claims-status/components/appeals-v2/Issues.jsx on lines 61..68

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 67.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                            if (remandListItems.length) {
                              remandSection = (
                                <div className="remand-section">
                                  <h4 className="vads-u-font-size--h5">Remand</h4>
                                  <ul>{remandListItems}</ul>
                          src/applications/claims-status/components/appeals-v2/Issues.jsx on lines 41..48
                          src/applications/claims-status/components/appeals-v2/Issues.jsx on lines 51..58
                          src/applications/claims-status/components/appeals-v2/Issues.jsx on lines 61..68

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 67.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                          Denied.propTypes = {
                            origin: PropTypes.oneOf(['form', 'status']).isRequired,
                            referenceNumber: PropTypes.string.isRequired,
                            requestDate: PropTypes.number.isRequired,
                            testUrl: PropTypes.string,
                          src/applications/lgy/coe/shared/components/StatusAlert/statuses/Denied.jsx on lines 30..35

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 67.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language