Showing 12,848 of 12,848 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
export default {
uiSchema: {
...titleUI(
({ formData }) => getVeteranIdentityInfoPageTitle(formData),
'You must enter either a Social Security number or VA File number',
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 64.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
<va-alert
status="warning"
visible
data-testid="service-is-down-banner"
uswds
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 64.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function saveForm
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
function saveForm(saveType, formId, formData, version, returnUrl, submission) {
const savedAt = Date.now();
return (dispatch, getState) => {
const { trackingPrefix } = getState().form;
Function render
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
render() {
const { form, formConfig, formContext, pageList, path, user } = this.props;
const { CustomReviewTopContent, hideReviewChapters } = formConfig;
const downtimeDependencies = get('downtime.dependencies', formConfig) || [];
Function fileInputUI
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const fileInputUI = stringOrOptions => {
if (typeof stringOrOptions === 'string') {
return {
'ui:title': stringOrOptions,
'ui:webComponentField': VaFileInputField,
Function render
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
render() {
const {
chapters,
form,
formConfig,
Function render
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
render() {
return (
<Modal
hideCloseButton
id="session-timeout-modal"
Function addressValidationSuccessTwoInternational
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
addressValidationSuccessTwoInternational() {
return asyncReturn(
{
addresses: [
{
Function render
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
render() {
const { submission, data } = this.props.form;
const { response } = submission;
const name = data.veteranFullName;
Function fetchDebtLettersVBMS
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const fetchDebtLettersVBMS = () => async dispatch => {
dispatch(fetchDebtLettersInitiated());
try {
const options = {
method: 'GET',
Function constructor
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
constructor(props) {
super(props);
// Throw an error if there’s no viewComponent (should be React component)
if (
!isReactComponent(get('ui:options.viewComponent', this.props.uiSchema))
Function IntroductionPage
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const IntroductionPage = props => {
useEffect(() => {
focusElement('h1');
scrollTo('topContentElement');
});
Function getEvidence
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const getEvidence = formData => {
const evidenceSubmission = {
evidenceType: [],
};
// Add VA evidence data
Function IntroText
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const IntroText = () => {
const restartWizard = () => {
recordEvent({ event: 'howToWizard-start-over' });
};
return (
Function getEvidence
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const getEvidence = formData => {
const evidenceSubmission = {
evidenceType: [],
};
// Add VA evidence data
Function render
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
render() {
const { submission, data } = this.props.form;
const { response } = submission;
const name = data.veteranFullName;
Function applicantMedigapSchema
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function applicantMedigapSchema(isPrimary) {
const keyname = isPrimary ? 'primaryMedigapPlan' : 'secondaryMedigapPlan';
return {
uiSchema: {
...titleUI(
Function MailingAddressInfoPage
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const MailingAddressInfoPage = () => {
const mailingAddress = useSelector(selectVAPMailingAddress);
const showSuccessAlert = window.sessionStorage.getItem(
'onReviewPageContactInfoEdit',
Function MailingAddressInfoPageTaskGreen
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export const MailingAddressInfoPageTaskGreen = () => {
const mailingAddress = useSelector(selectVAPMailingAddress);
const showSuccessAlert = window.sessionStorage.getItem(
'onReviewPageContactInfoEdit',
Function searchByCoordinates
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
static searchByCoordinates(
address = null,
lat,
long,
name,