department-of-veterans-affairs/vets-website

View on GitHub

Showing 12,852 of 12,852 total issues

Function useAlerts has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const useAlerts = dispatch => {
  const alertList = useSelector(state => state.mr.alerts?.alertList);
  const [activeAlert, setActiveAlert] = useState();

  useEffect(
Severity: Minor
Found in src/applications/mhv-medical-records/hooks/use-alerts.js - About 1 hr to fix

    Function submitEmail has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function submitEmail(email) {
      recordEvent({ event: 'vic-email-started' });
      return dispatch => {
        dispatch({ type: VIC_EMAIL_CAPTURING });
    
    
    Severity: Minor
    Found in src/applications/veteran-id-card/actions/index.js - About 1 hr to fix

      Function LabsAndTestsListItem has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const LabsAndTestsListItem = props => {
        const { record } = props;
      
        return (
          <va-card

        Function ConditionListItem has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const ConditionListItem = props => {
          const { record } = props;
        
          return (
            <va-card

          Function allergiesReducer has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export const allergiesReducer = (state = initialState, action) => {
            switch (action.type) {
              case Actions.Allergies.GET_LIST: {
                return {
                  ...state,
          Severity: Minor
          Found in src/applications/mhv-medications/reducers/allergies.js - About 1 hr to fix

            Function dropdownContent has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    const dropdownContent = () => {
                      return (
                        <>
                          <p className="vads-u-padding-bottom--1">
                            A VA provider added this medication record in your VA medical

              Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                render() {
                  let content;
              
                  switch (this.props.serviceAvailability) {
                    case SERVICE_AVAILABILITY_STATES.unrequested: {

                Consider simplifying this complex logical expression.
                Open

                    } else if (prefillEnabled && !verifyRequiredPrefill) {
                      const H = `h${this.props.headingLevel}`;
                      const {
                        buttonOnly,
                        retentionPeriod,
                Severity: Major
                Found in src/platform/forms/save-in-progress/SaveInProgressIntro.jsx - About 1 hr to fix

                  Consider simplifying this complex logical expression.
                  Open

                      if (
                        nextProps.reviewMode &&
                        !nextProps.editModeOnReviewPage &&
                        nextProps.reviewMode === this.props.reviewMode &&
                        deepEquals(this.state, nextState) &&
                  Severity: Major
                  Found in src/platform/forms-system/src/js/components/SchemaForm.jsx - About 1 hr to fix

                    Consider simplifying this complex logical expression.
                    Open

                          } else if (
                            allowITF &&
                            !isCreating &&
                            !hasActiveITF &&
                            !createITFCalled &&
                    Severity: Major
                    Found in src/applications/appeals/995/containers/ITFWrapper.jsx - About 1 hr to fix

                      Consider simplifying this complex logical expression.
                      Open

                            } else if (
                              allowITF &&
                              !isCreating &&
                              !hasActiveITF &&
                              !createITFCalled &&
                      Severity: Major
                      Found in src/applications/appeals/testing/sc/containers/ITFWrapper.jsx - About 1 hr to fix

                        Consider simplifying this complex logical expression.
                        Open

                            if (
                              nextProps.reviewMode &&
                              !nextProps.editModeOnReviewPage &&
                              nextProps.reviewMode === this.props.reviewMode &&
                              deepEquals(this.state, nextState) &&

                          Consider simplifying this complex logical expression.
                          Open

                                  if (
                                    [SENT_DATE_DESCENDING.value, DRAFT_DATE_DESCENDING.value].includes(
                                      sortOrder,
                                    ) ||
                                    (sortOrder === SENDER_ALPHA_ASCENDING.value &&

                            Consider simplifying this complex logical expression.
                            Open

                              if (
                                errorCodes.some(
                                  code =>
                                    code === 10001 ||
                                    code === 10006 ||

                              Consider simplifying this complex logical expression.
                              Open

                                    if (
                                      ((prescriptionsFullList?.length &&
                                        pdfTxtGenerateStatus.format !== PRINT_FORMAT.PRINT) ||
                                        (pdfTxtGenerateStatus.format === PRINT_FORMAT.PRINT &&
                                          paginatedPrescriptionsList?.length)) &&
                              Severity: Major
                              Found in src/applications/mhv-medications/containers/Prescriptions.jsx - About 1 hr to fix

                                Identical blocks of code found in 7 locations. Consider refactoring.
                                Open

                                export async function getData(apiRoute, options) {
                                  try {
                                    const response = await apiRequest(apiRoute, options);
                                    return response.data.attributes;
                                  } catch (error) {
                                src/applications/disability-benefits/686c-674-v2/utils/index.js on lines 6..13
                                src/applications/disability-benefits/686c-674/config/utilities.js on lines 18..25
                                src/applications/disability-benefits/686c-674/util/index.js on lines 6..13
                                src/applications/personalization/view-dependents/util/index.js on lines 10..17
                                src/applications/rated-disabilities/util/index.js on lines 7..14
                                src/platform/user/profile/utilities/index.js on lines 165..172

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 55.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 7 locations. Consider refactoring.
                                Open

                                export async function getData(apiRoute, options) {
                                  try {
                                    const response = await apiRequest(apiRoute, options);
                                    return response.data.attributes;
                                  } catch (error) {
                                Severity: Major
                                Found in src/applications/rated-disabilities/util/index.js and 6 other locations - About 1 hr to fix
                                src/applications/disability-benefits/686c-674-v2/config/utilities.js on lines 19..26
                                src/applications/disability-benefits/686c-674-v2/utils/index.js on lines 6..13
                                src/applications/disability-benefits/686c-674/config/utilities.js on lines 18..25
                                src/applications/disability-benefits/686c-674/util/index.js on lines 6..13
                                src/applications/personalization/view-dependents/util/index.js on lines 10..17
                                src/platform/user/profile/utilities/index.js on lines 165..172

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 55.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 7 locations. Consider refactoring.
                                Open

                                export async function getData(apiRoute, options) {
                                  try {
                                    const response = await apiRequest(apiRoute, options);
                                    return response.data.attributes;
                                  } catch (error) {
                                Severity: Major
                                Found in src/platform/user/profile/utilities/index.js and 6 other locations - About 1 hr to fix
                                src/applications/disability-benefits/686c-674-v2/config/utilities.js on lines 19..26
                                src/applications/disability-benefits/686c-674-v2/utils/index.js on lines 6..13
                                src/applications/disability-benefits/686c-674/config/utilities.js on lines 18..25
                                src/applications/disability-benefits/686c-674/util/index.js on lines 6..13
                                src/applications/personalization/view-dependents/util/index.js on lines 10..17
                                src/applications/rated-disabilities/util/index.js on lines 7..14

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 55.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 7 locations. Consider refactoring.
                                Open

                                export async function getData(apiRoute, options) {
                                  try {
                                    const response = await apiRequest(apiRoute, options);
                                    return response.data.attributes;
                                  } catch (error) {
                                src/applications/disability-benefits/686c-674-v2/config/utilities.js on lines 19..26
                                src/applications/disability-benefits/686c-674-v2/utils/index.js on lines 6..13
                                src/applications/disability-benefits/686c-674/config/utilities.js on lines 18..25
                                src/applications/personalization/view-dependents/util/index.js on lines 10..17
                                src/applications/rated-disabilities/util/index.js on lines 7..14
                                src/platform/user/profile/utilities/index.js on lines 165..172

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 55.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 7 locations. Consider refactoring.
                                Open

                                export async function getData(apiRoute, options) {
                                  try {
                                    const response = await apiRequest(apiRoute, options);
                                    return response.data.attributes;
                                  } catch (error) {
                                src/applications/disability-benefits/686c-674-v2/config/utilities.js on lines 19..26
                                src/applications/disability-benefits/686c-674-v2/utils/index.js on lines 6..13
                                src/applications/disability-benefits/686c-674/util/index.js on lines 6..13
                                src/applications/personalization/view-dependents/util/index.js on lines 10..17
                                src/applications/rated-disabilities/util/index.js on lines 7..14
                                src/platform/user/profile/utilities/index.js on lines 165..172

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 55.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language