Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/ProfileInformationFieldController.jsx

Summary

Maintainability
F
3 wks
Test Coverage

File ProfileInformationFieldController.jsx has 514 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import PropTypes from 'prop-types';
import { connect } from 'react-redux';

// platform level imports
Severity: Major
Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/ProfileInformationFieldController.jsx - About 1 day to fix

    Function render has 171 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render() {
    const {
      activeEditView,
      fieldName,
      isEmpty,
    Severity: Major
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/ProfileInformationFieldController.jsx - About 6 hrs to fix

      Function componentDidUpdate has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        componentDidUpdate(prevProps) {
    const {
      fieldName,
      forceEditView,
      successCallback,
      Severity: Minor
      Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/ProfileInformationFieldController.jsx - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function mapStateToProps has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const mapStateToProps = (state, ownProps) => {
  const { fieldName } = ownProps;

  const { transaction, transactionRequest } = selectVAPServiceTransaction(
    state,
      Severity: Minor
      Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/ProfileInformationFieldController.jsx - About 1 hr to fix

        Function componentDidUpdate has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          componentDidUpdate(prevProps) {
    const {
      fieldName,
      forceEditView,
      successCallback,
        Severity: Minor
        Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/ProfileInformationFieldController.jsx - About 1 hr to fix

          Function render has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            render() {
    const {
      activeEditView,
      fieldName,
      isEmpty,
          Severity: Minor
          Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/ProfileInformationFieldController.jsx - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          class ProfileInformationFieldController extends React.Component {
  closeModalTimeoutID = null;

  constructor(props) {
    super(props);
          Severity: Major
          Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/ProfileInformationFieldController.jsx and 1 other location - About 2 wks to fix
          src/platform/user/profile/vap-svc/components/ProfileInformationFieldController.jsx on lines 72..478

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 2606.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          ProfileInformationFieldController.propTypes = {
  analyticsSectionName: PropTypes.oneOf(
    Object.values(VAP_SERVICE.ANALYTICS_FIELD_MAP),
  ).isRequired,
  apiRoute: PropTypes.oneOf(Object.values(VAP_SERVICE.API_ROUTES)).isRequired,
          Severity: Major
          Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/ProfileInformationFieldController.jsx and 1 other location - About 2 days to fix
          src/platform/user/profile/vap-svc/components/ProfileInformationFieldController.jsx on lines 491..531

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 437.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          export const mapStateToProps = (state, ownProps) => {
  const { fieldName } = ownProps;

  const { transaction, transactionRequest } = selectVAPServiceTransaction(
    state,
          Severity: Major
          Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/ProfileInformationFieldController.jsx and 1 other location - About 2 days to fix
          src/platform/user/profile/vap-svc/components/ProfileInformationFieldController.jsx on lines 533..593

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 360.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          const shouldShowUpdateSuccessAlert = (state, field) => {
  const mostRecentSaveField = selectMostRecentlyUpdatedField(state);
  return Array.isArray(mostRecentSaveField)
    ? mostRecentSaveField.includes(field)
    : mostRecentSaveField === field;
          Severity: Minor
          Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/ProfileInformationFieldController.jsx and 1 other location - About 55 mins to fix
          src/platform/user/profile/vap-svc/components/ProfileInformationFieldController.jsx on lines 480..485

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status