department-of-veterans-affairs/vets-website

View on GitHub
src/applications/_mock-form-ae-design-patterns/patterns/pattern1/ezr/VeteranProfileInformation.jsx

Summary

Maintainability
F
4 days
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

const VeteranProfileInformation = ({
  goBack,
  goForward,
  profile,
  veteran,
src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskGreen/VeteranProfileInformation.jsx on lines 12..115

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 701.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

VeteranProfileInformation.propTypes = {
  contentAfterButtons: PropTypes.element,
  contentBeforeButtons: PropTypes.element,
  goBack: PropTypes.func,
  goForward: PropTypes.func,
src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskGreen/VeteranProfileInformation.jsx on lines 117..124
src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskYellow/VeteranProfileInformationTaskYellow.jsx on lines 117..124
src/applications/appeals/shared/content/contestableIssues.jsx on lines 116..123
src/applications/caregivers/components/FormFields/FacilityList.jsx on lines 92..99
src/applications/claims-status/components/ClaimDetailLayout.jsx on lines 135..142
src/applications/claims-status/containers/ClaimStatusPage.jsx on lines 140..147
src/applications/claims-status/containers/OverviewPage.jsx on lines 147..154
src/applications/combined-debt-portal/medical-copays/components/AccountSummary.jsx on lines 59..66
src/applications/ezr/components/FormPages/VeteranProfileInformation.jsx on lines 110..117
src/applications/financial-status-report/components/veteranInformation/VeteranInfoBox.jsx on lines 51..58
src/applications/hca/components/FormFields/VaMedicalCenter.jsx on lines 238..245
src/applications/mhv-medications/components/MedicationsList/MedicationsList.jsx on lines 106..113
src/applications/mhv-secure-messaging/components/ComposeForm/CategoryInput.jsx on lines 64..71
src/applications/mhv-secure-messaging/components/MessageActionButtons/MoveMessageToFolderBtn.jsx on lines 250..257
src/applications/mhv-secure-messaging/components/MessageList/MessageList.jsx on lines 228..235
src/applications/mhv-secure-messaging/components/MessageThreadHeader.jsx on lines 155..162
src/applications/mhv-secure-messaging/components/Modals/DeleteDraftModal.jsx on lines 48..55
src/applications/representative-appoint/components/ContactCard.jsx on lines 57..64
src/applications/static-pages/facilities/vet-center/NearByVetCenters.jsx on lines 246..253
src/applications/vaos/covid-19-vaccine/components/ConfirmationPageV2.jsx on lines 159..166
src/applications/verify-your-enrollment/components/MoreInfoCard.jsx on lines 47..54
src/applications/verify-your-enrollment/components/PayeeInformationCard.jsx on lines 73..80
src/platform/user/authentication/components/VerifyButton.jsx on lines 45..52
src/applications/vaos/components/FacilityPhone.jsx on lines 49..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status