department-of-veterans-affairs/vets-website

View on GitHub
src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/EditContactInfo.jsx

Summary

Maintainability
C
1 day
Test Coverage

Function BuildPage has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const BuildPage = props => {
  const { title, field, id, goToPath, subTitle } = props;

  const headerRef = useRef(null);

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          <div className="va-profile-wrapper" onSubmit={handlers.onSubmit}>
            <InitializeVAPServiceID>
              {subTitle && <p className="vads-u-color--gray-medium">{subTitle}</p>}
              <ProfileInformationFieldController
                forceEditView
    src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/EditContactInfo.jsx on lines 96..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

    BuildPage.propTypes = {
      contactPath: PropTypes.string,
      data: PropTypes.object,
      field: PropTypes.string,
      goToPath: PropTypes.func,
    src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/EditContactInfo.jsx on lines 112..121
    src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskGray/form/components/EditContactInfo.jsx on lines 96..105
    src/applications/ask-va/containers/CategorySelectPage.jsx on lines 137..146
    src/applications/ask-va/containers/SubTopicSelectPage.jsx on lines 119..128
    src/applications/education-letters/containers/InboxPage.jsx on lines 102..111
    src/applications/gi/components/LearnMoreLabel.jsx on lines 70..79
    src/applications/gi/containers/search/LocationSearchResults.jsx on lines 859..868
    src/applications/mhv-secure-messaging/components/MessageActionButtons.jsx on lines 92..101
    src/applications/mhv-secure-messaging/components/Search/FilterBox.jsx on lines 173..182
    src/applications/mhv-secure-messaging/components/ThreadList/ThreadsList.jsx on lines 123..132
    src/applications/personalization/dashboard/components/CTALink.jsx on lines 43..52
    src/applications/personalization/view-dependents/layouts/ViewDependentsLayout.jsx on lines 72..81
    src/applications/personalization/view-dependents/manage-dependents/containers/ManageDependentsApp.jsx on lines 148..157
    src/applications/toe/containers/SponsorsSelectionPage.jsx on lines 98..107
    src/applications/travel-pay/components/TravelClaimCard.jsx on lines 69..78
    src/applications/travel-pay/components/TravelPayClaimFilters.jsx on lines 58..67
    src/platform/forms/components/review/FormSaveErrorMessage.jsx on lines 129..138

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 84.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status