Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskOrange/utils/labels.jsx

Summary

Maintainability
F
6 days
Test Coverage

File labels.jsx has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';

import { states } from 'platform/forms/address';
import { createUSAStateLabels } from 'platform/forms-system/src/js/helpers';
Severity: Minor
Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskOrange/utils/labels.jsx - About 3 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    export const benefitsLabels = {
  chapter33: (
    <p>
      Post-9/11 GI Bill (Chapter 33)
      <br />
    Severity: Major
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskOrange/utils/labels.jsx and 1 other location - About 1 day to fix
    src/applications/edu-benefits/utils/labels.jsx on lines 17..106

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 354.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    export const benefitsLabelsUpdate = {
  chapter33: (
    <p>
      Post-9/11 GI Bill (Chapter 33)
      <br />
    Severity: Major
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskOrange/utils/labels.jsx and 1 other location - About 1 day to fix
    src/applications/edu-benefits/utils/labels.jsx on lines 108..195

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 348.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    export const directDepositWarning = (
  <div className="edu-dd-warning">
    <p>
      The Department of the Treasury requires all federal benefit payments be
      made by electronic funds transfer (EFT), also called direct deposit.
    Severity: Major
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskOrange/utils/labels.jsx and 1 other location - About 6 hrs to fix
    src/applications/edu-benefits/utils/labels.jsx on lines 267..299

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 165.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    export const survivorBenefitsLabels = {
  chapter35: (
    <p>
      <span aria-describedby="conditional-warning-text">
        Survivors’ and Dependents’ Educational Assistance
    Severity: Major
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskOrange/utils/labels.jsx and 1 other location - About 6 hrs to fix
    src/applications/edu-benefits/utils/labels.jsx on lines 198..231

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 161.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    export const bankInfoHelpText = (
  <va-additional-info
    trigger="What if I don’t have a bank account?"
    onClick={gaBankInfoHelpText}
  >
    Severity: Major
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskOrange/utils/labels.jsx and 2 other locations - About 3 hrs to fix
    src/applications/edu-benefits/0994/content/bankInformation.jsx on lines 22..46
    src/applications/edu-benefits/utils/labels.jsx on lines 308..332

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

    export const chapterNames = {
  veteranInformation: 'Veteran Information',
  benefitsEligibility: 'Benefits Eligibility',
  militaryHistory: 'Military History',
  educationHistory: 'Education History',
    Severity: Major
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskOrange/utils/labels.jsx and 11 other locations - About 50 mins to fix
    src/applications/appeals/995/content/primaryPhone.js on lines 1..11
    src/applications/appeals/testing/sc/content/primaryPhone.js on lines 1..11
    src/applications/disability-benefits/686c-674/config/constants.js on lines 7..17
    src/applications/disability-benefits/wizard/pages/pageList.js on lines 1..10
    src/applications/edu-benefits/utils/labels.jsx on lines 6..15
    src/applications/mhv-medical-records/util/constants.js on lines 23..32
    src/applications/mhv-secure-messaging/util/constants.js on lines 308..317
    src/applications/simple-forms/21-4142/definitions/constants.js on lines 29..38
    src/applications/vre/28-1900/wizard/pages/pageList.js on lines 14..23
    src/applications/pensions/labels.jsx on lines 32..41
    src/applications/static-pages/cta-widget/constants.js on lines 3..12

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status