Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/_mock-form-ae-design-patterns/patterns/pattern2/post-study/UneditableData.jsx

Summary

Maintainability
D
2 days
Test Coverage

Function UneditableData has 152 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const UneditableData = () => {
  const name = `${USER.FIRST_NAME} ${USER.MIDDLE_NAME} ${USER.LAST_NAME}`;
  const parsedDob = parse(USER.BIRTH_DATE, 'yyyyMMdd', new Date());
  const dob = format(parsedDob, 'MMMM d, yyyy');
  const gender = genderLabels[USER.GENDER];
Severity: Major
Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/post-study/UneditableData.jsx - About 6 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              <div>
            <p className="vads-u-margin-top--5 vads-u-padding-bottom--9">
              <strong>Note:</strong> To protect your personal information, we
              don’t allow online changes to your name, Social Security number,
              date of birth, or gender. If you need to change this information,
    Severity: Major
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/post-study/UneditableData.jsx and 1 other location - About 2 hrs to fix
    src/applications/_mock-form-ae-design-patterns/patterns/pattern2/post-study/UneditableData.jsx on lines 179..196

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              <div className="vads-u-padding-bottom--7">
            <p className="vads-u-margin-top--4">
              <strong>Note:</strong> To protect your personal information, we
              don’t allow online changes to your name, Social Security number,
              date of birth, or gender. If you need to change this information,
    Severity: Major
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/post-study/UneditableData.jsx and 1 other location - About 2 hrs to fix
    src/applications/_mock-form-ae-design-patterns/patterns/pattern2/post-study/UneditableData.jsx on lines 119..136

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                <p className="ssn">
              <strong>Last 4 digits of Social Security number: </strong>
              <span data-dd-action-name="Veteran's SSN">
                {veteranSsn.slice(-4)}
              </span>
    Severity: Major
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/post-study/UneditableData.jsx and 1 other location - About 1 hr to fix
    src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskBlue/VeteranInformation.jsx on lines 50..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          <p className="vads-u-margin-top--0">
        To protect your personal information, we don’t allow online changes to
        your name, Social Security number, date of birth, or gender. If you need
        change this information, call us at{' '}
        <va-telephone contact="8008271000" /> (
    Severity: Major
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/post-study/UneditableData.jsx and 1 other location - About 1 hr to fix
    src/applications/combined-debt-portal/combined/components/DisasterAlert.jsx on lines 37..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                <p>
              <strong>Gender: </strong>
              <span
                className="gender dd-privacy-hidden"
                data-dd-action-name="Veteran's gender"
    Severity: Minor
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/post-study/UneditableData.jsx and 1 other location - About 50 mins to fix
    src/applications/_mock-form-ae-design-patterns/patterns/pattern2/post-study/UneditableData.jsx on lines 108..116

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                <p>
              <strong>Gender: </strong>
              <span
                className="gender dd-privacy-hidden"
                data-dd-action-name="Veteran's gender"
    Severity: Minor
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/post-study/UneditableData.jsx and 1 other location - About 50 mins to fix
    src/applications/_mock-form-ae-design-patterns/patterns/pattern2/post-study/UneditableData.jsx on lines 168..176

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                <p className="ssn">
              <strong>Social Security number: </strong>
              <span data-dd-action-name="Veteran's SSN">{maskedSsn}</span>
            </p>
    Severity: Major
    Found in src/applications/_mock-form-ae-design-patterns/patterns/pattern2/post-study/UneditableData.jsx and 2 other locations - About 45 mins to fix
    src/applications/hca/components/FormReview/VaMedicalCenterReviewField.jsx on lines 6..9
    src/applications/hca/components/FormReview/VaMedicalCenterReviewField.jsx on lines 10..13

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status