Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/appeals/995/components/ConfirmationPageV2.jsx

Summary

Maintainability
D
2 days
Test Coverage

Function ConfirmationPageV2 has 239 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const ConfirmationPageV2 = () => {
  resetStoredSubTask();

  const form = useSelector(state => state.form || {});
  const profile = useSelector(state => selectProfile(state));
Severity: Major
Found in src/applications/appeals/995/components/ConfirmationPageV2.jsx - About 1 day to fix

    File ConfirmationPageV2.jsx has 288 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React from 'react';
import PropTypes from 'prop-types';
import { useSelector } from 'react-redux';

import { CONTACTS } from '@department-of-veterans-affairs/component-library/contacts';
    Severity: Minor
    Found in src/applications/appeals/995/components/ConfirmationPageV2.jsx - About 2 hrs to fix

      Function ConfirmationPageV2 has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      export const ConfirmationPageV2 = () => {
  resetStoredSubTask();

  const form = useSelector(state => state.form || {});
  const profile = useSelector(state => selectProfile(state));
      Severity: Minor
      Found in src/applications/appeals/995/components/ConfirmationPageV2.jsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              <li>
          <div className="vads-u-margin-bottom--0p5 vads-u-color--gray vads-u-font-size--sm">
            Option to add an indicator
          </div>
          <div
      Severity: Major
      Found in src/applications/appeals/995/components/ConfirmationPageV2.jsx and 1 other location - About 1 hr to fix
      src/applications/appeals/10182/components/ConfirmationPageV2.jsx on lines 228..238

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      <li>
                  <div className="vads-u-margin-bottom--0p5 vads-u-color--gray vads-u-font-size--sm">
                    {pointOfContactNameLabel}
                  </div>
                  <div
      Severity: Major
      Found in src/applications/appeals/995/components/ConfirmationPageV2.jsx and 1 other location - About 1 hr to fix
      src/applications/appeals/995/components/ConfirmationPageV2.jsx on lines 165..175

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                        <li>
                    <div className="vads-u-margin-bottom--0p5 vads-u-color--gray vads-u-font-size--sm">
                      {otherHousingRisksLabel}
                    </div>
                    <div
      Severity: Major
      Found in src/applications/appeals/995/components/ConfirmationPageV2.jsx and 1 other location - About 1 hr to fix
      src/applications/appeals/995/components/ConfirmationPageV2.jsx on lines 177..187

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      ConfirmationPageV2.propTypes = {
  children: PropTypes.element,
  form: PropTypes.shape({
    data: PropTypes.shape({}),
    formId: PropTypes.string,
      Severity: Major
      Found in src/applications/appeals/995/components/ConfirmationPageV2.jsx and 1 other location - About 1 hr to fix
      src/applications/appeals/996/components/ConfirmationPageV2.jsx on lines 242..248

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            <p>
        You can also call us at <va-telephone contact={CONTACTS.VA_BENEFITS} />{' '}
        <va-telephone contact={CONTACTS[711]} tty />
        ).
      </p>
      Severity: Major
      Found in src/applications/appeals/995/components/ConfirmationPageV2.jsx and 1 other location - About 1 hr to fix
      src/applications/appeals/testing/sc/containers/ConfirmationPage.jsx on lines 41..45

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              <>
          <h3 className="vads-u-margin-top--2">
            {evidenceContent.summaryTitle}
          </h3>
          <div className="no-evidence">
      Severity: Minor
      Found in src/applications/appeals/995/components/ConfirmationPageV2.jsx and 1 other location - About 55 mins to fix
      src/applications/static-pages/dependency-verification/components/dependencyVerificationList.jsx on lines 8..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status