department-of-veterans-affairs/vets-website

View on GitHub
src/applications/appeals/995/content/OmbInfo.jsx

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    <va-omb-info res-burden="10" omb-number="2900-0858" exp-date="7/31/2024">
      <p>
        <strong>Respondent Burden:</strong> We need this information and your
        written authorization to obtain your treatment records to help us get
        the information required to process your claim. Title 38, United States
Severity: Major
Found in src/applications/appeals/995/content/OmbInfo.jsx and 3 other locations - About 4 hrs to fix
src/applications/appeals/995/content/OmbInfo.jsx on lines 16..66
src/applications/appeals/testing/sc/content/OmbInfo.jsx on lines 13..63
src/applications/appeals/testing/sc/content/OmbInfo.jsx on lines 68..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 124.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    <va-omb-info res-burden="15" omb-number="2900-0886" exp-date="4/30/2024">
      <p>
        <strong>Respondent Burden:</strong> We need this information to
        determine entitlement to benefits (38 U.S.C. 501). Title 38, United
        States Code, allows us to ask for this information. We estimate that you
Severity: Major
Found in src/applications/appeals/995/content/OmbInfo.jsx and 3 other locations - About 4 hrs to fix
src/applications/appeals/995/content/OmbInfo.jsx on lines 70..124
src/applications/appeals/testing/sc/content/OmbInfo.jsx on lines 13..63
src/applications/appeals/testing/sc/content/OmbInfo.jsx on lines 68..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 124.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status