Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/appeals/testing/nod-new/components/ContestableIssuesWidget.jsx

Summary

Maintainability
D
2 days
Test Coverage

Function ContestableIssuesWidget has 210 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const ContestableIssuesWidget = props => {
  const {
    value = [],
    id,
    options,
Severity: Major
Found in src/applications/appeals/testing/nod-new/components/ContestableIssuesWidget.jsx - About 1 day to fix

    Function ContestableIssuesWidget has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    const ContestableIssuesWidget = props => {
  const {
    value = [],
    id,
    options,
    Severity: Minor
    Found in src/applications/appeals/testing/nod-new/components/ContestableIssuesWidget.jsx - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File ContestableIssuesWidget.jsx has 284 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React, { useEffect, useState } from 'react';
import PropTypes from 'prop-types';
import { connect } from 'react-redux';
import { Link } from 'react-router';
import { VaModal } from '@department-of-veterans-affairs/component-library/dist/react-bindings';
    Severity: Minor
    Found in src/applications/appeals/testing/nod-new/components/ContestableIssuesWidget.jsx - About 2 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              <VaModal
          clickToClose
          status="warning"
          modalTitle={removeModalContent.title}
          primaryButtonText={removeModalContent.yesButton}
      Severity: Major
      Found in src/applications/appeals/testing/nod-new/components/ContestableIssuesWidget.jsx and 1 other location - About 2 hrs to fix
      src/applications/appeals/shared/components/ContestableIssues.jsx on lines 222..241

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 89.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {onReviewPage && inReviewMode ? null : (
          <Link
            className="add-new-issue vads-c-action-link--green"
            to={{
              pathname: '/add-issue',
      Severity: Major
      Found in src/applications/appeals/testing/nod-new/components/ContestableIssuesWidget.jsx and 1 other location - About 1 hr to fix
      src/applications/appeals/shared/components/ContestableIssues.jsx on lines 245..255

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          onRemoveModalClose: () => {
      focusIssue(null, null, `${value.length + removeIndex},remove-cancel`);
      setShowRemoveModal(false);
      setRemoveIndex(null);
    },
      Severity: Minor
      Found in src/applications/appeals/testing/nod-new/components/ContestableIssuesWidget.jsx and 1 other location - About 45 mins to fix
      src/applications/appeals/shared/components/ContestableIssues.jsx on lines 157..165

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status