Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/appeals/testing/sc/containers/ITFWrapper.jsx

Summary

Maintainability
F
4 days
Test Coverage

Function ITFWrapper has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

const ITFWrapper = ({
  // loggedIn,
  benefitType,
  pathname,
  children,
Severity: Minor
Found in src/applications/appeals/testing/sc/containers/ITFWrapper.jsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

      } else if (
        allowITF &&
        !isCreating &&
        !hasActiveITF &&
        !createITFCalled &&
Severity: Major
Found in src/applications/appeals/testing/sc/containers/ITFWrapper.jsx - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

      return (
    <ITFBanner status="error" router={router}>
      {children}
    </ITFBanner>
  );
    Severity: Major
    Found in src/applications/appeals/testing/sc/containers/ITFWrapper.jsx - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return showLoading(
      'Submitting a new Intent to File...',
      'submitting a new intent to file',
    );
      Severity: Major
      Found in src/applications/appeals/testing/sc/containers/ITFWrapper.jsx - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return (
      <ITFBanner
        status={status}
        currentExpDate={currentExpDate}
        router={router}
        Severity: Major
        Found in src/applications/appeals/testing/sc/containers/ITFWrapper.jsx - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            useEffect(
    () => {
      const hasActiveITF = isActiveITF(itf.currentITF);
      const createITFCalled =
        hasActiveITF && itf.creationCallState !== requestStates.notCalled;
          Severity: Major
          Found in src/applications/appeals/testing/sc/containers/ITFWrapper.jsx and 1 other location - About 1 day to fix
          src/applications/appeals/995/containers/ITFWrapper.jsx on lines 37..79

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 239.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            if (itf?.currentITF?.status === ITF_STATUSES.active) {
    const status =
      itf.creationCallState === 'succeeded' ? 'itf-created' : 'itf-found';
    const { expirationDate: currentExpDate } = itf.currentITF;
          Severity: Major
          Found in src/applications/appeals/testing/sc/containers/ITFWrapper.jsx and 1 other location - About 1 day to fix
          src/applications/appeals/995/containers/ITFWrapper.jsx on lines 104..136

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 195.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          ITFWrapper.propTypes = {
  children: PropTypes.any.isRequired,
  loggedIn: PropTypes.bool.isRequired,
  pathname: PropTypes.string.isRequired,
  router: PropTypes.shape({
          Severity: Major
          Found in src/applications/appeals/testing/sc/containers/ITFWrapper.jsx and 1 other location - About 7 hrs to fix
          src/applications/appeals/995/containers/ITFWrapper.jsx on lines 169..186

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 188.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

          const itfShape = {
  id: PropTypes.string,
  creationDate: PropTypes.string,
  expirationDate: PropTypes.string.isRequired,
  participantId: PropTypes.number,
          Severity: Major
          Found in src/applications/appeals/testing/sc/containers/ITFWrapper.jsx and 2 other locations - About 2 hrs to fix
          src/applications/appeals/995/containers/ITFWrapper.jsx on lines 159..167
          src/applications/disability-benefits/all-claims/containers/ITFWrapper.jsx on lines 158..166

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            if (itf.fetchCallState === requestStates.failed) {
    // We'll get here after the fetchITF promise is fulfilled
    // render children to allow testing in non-production environment
    return (
      <ITFBanner status="error" router={router}>
          Severity: Minor
          Found in src/applications/appeals/testing/sc/containers/ITFWrapper.jsx and 1 other location - About 50 mins to fix
          src/applications/appeals/995/containers/ITFWrapper.jsx on lines 94..102

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status