Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/ask-va/containers/IntroductionPage.jsx

Summary

Maintainability
F
6 days
Test Coverage

Function IntroductionPage has 327 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const IntroductionPage = props => {
  const { route, toggleLoginModal, loggedIn } = props;
  const { formConfig, pageList, pathname, formData } = route;
  const [inquiryData, setInquiryData] = useState(false);
  const [searchReferenceNumber, setSearchReferenceNumber] = useState('');
Severity: Major
Found in src/applications/ask-va/containers/IntroductionPage.jsx - About 1 day to fix

    File IntroductionPage.jsx has 395 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
  VaAlert,
  VaButton,
  VaSearchInput,
} from '@department-of-veterans-affairs/component-library/dist/react-bindings';
    Severity: Minor
    Found in src/applications/ask-va/containers/IntroductionPage.jsx - About 5 hrs to fix

      Function questionStatus has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const questionStatus = () => {
    if (hasError) {
      return (
        <>
          <p>
      Severity: Major
      Found in src/applications/ask-va/containers/IntroductionPage.jsx - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

            if (inquiryData?.attributes?.status) {
      const { status } = inquiryData.attributes;
      return (
        <>
          <h3 className="vads-u-font-weight--normal vads-u-font-size--base vads-u-font-family--sans vads-u-border-bottom--2px vads-u-border-color--gray-light vads-u-padding-bottom--2">
        Severity: Critical
        Found in src/applications/ask-va/containers/IntroductionPage.jsx - About 1 hr to fix

          Function IntroductionPage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          const IntroductionPage = props => {
  const { route, toggleLoginModal, loggedIn } = props;
  const { formConfig, pageList, pathname, formData } = route;
  const [inquiryData, setInquiryData] = useState(false);
  const [searchReferenceNumber, setSearchReferenceNumber] = useState('');
          Severity: Minor
          Found in src/applications/ask-va/containers/IntroductionPage.jsx - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                <div className="vads-u-margin-top--5 vads-u-margin-bottom--5">
        <va-accordion
          disable-analytics={{
            value: 'false',
          }}
          Severity: Major
          Found in src/applications/ask-va/containers/IntroductionPage.jsx and 1 other location - About 1 day to fix
          src/applications/ask-va/containers/IntroductionPage.jsx on lines 260..303

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 236.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                <div className="vads-u-margin-top--5 vads-u-margin-bottom--5">
        <va-accordion
          disable-analytics={{
            value: 'false',
          }}
          Severity: Major
          Found in src/applications/ask-va/containers/IntroductionPage.jsx and 1 other location - About 1 day to fix
          src/applications/ask-va/containers/IntroductionPage.jsx on lines 316..359

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 236.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                    <p className="vads-u-margin-top--0">
            You’ll need to sign in with a verified{' '}
            <span className="vads-u-font-weight--bold">Login.gov</span> or{' '}
            <span className="vads-u-font-weight--bold">ID.me</span> account or a
            Premium <span className="vads-u-font-weight--bold">DS Logon</span>{' '}
          Severity: Major
          Found in src/applications/ask-va/containers/IntroductionPage.jsx and 1 other location - About 4 hrs to fix
          src/applications/ask-va/containers/IntroductionPage.jsx on lines 188..196

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                    <p className="vads-u-margin-top--0">
            You’ll need to sign in with a verified{' '}
            <span className="vads-u-font-weight--bold">Login.gov</span> or{' '}
            <span className="vads-u-font-weight--bold">ID.me</span> account or a
            Premium <span className="vads-u-font-weight--bold">DS Logon</span>{' '}
          Severity: Major
          Found in src/applications/ask-va/containers/IntroductionPage.jsx and 1 other location - About 4 hrs to fix
          src/applications/ask-va/containers/IntroductionPage.jsx on lines 163..171

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  <li>
          <strong>If you think your life or health is in danger,</strong> call{' '}
          <va-telephone contact="911" message-aria-describedby="9 1 1" /> or go
          to the nearest emergency room.
        </li>
          Severity: Minor
          Found in src/applications/ask-va/containers/IntroductionPage.jsx and 2 other locations - About 35 mins to fix
          src/applications/disability-benefits/686c-674-v2/containers/ConfirmationPage.jsx on lines 96..102
          src/applications/hca/components/IntroductionPage/GetStarted/ProcessTimeline.jsx on lines 17..25

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status