Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/ask-va/containers/ReviewPage.jsx

Summary

Maintainability
F
1 wk
Test Coverage

Function ReviewPage has 237 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const ReviewPage = props => {
  const [showAlert, setShowAlert] = useState(true);
  const dispatch = useDispatch();

  const scrollToChapter = chapterKey => {
Severity: Major
Found in src/applications/ask-va/containers/ReviewPage.jsx - About 1 day to fix

    File ReviewPage.jsx has 419 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
  VaAccordion,
  VaAccordionItem,
  VaAlert,
} from '@department-of-veterans-affairs/component-library/dist/react-bindings';
    Severity: Minor
    Found in src/applications/ask-va/containers/ReviewPage.jsx - About 6 hrs to fix

      Function mapStateToProps has 136 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function mapStateToProps(state, ownProps) {
  const { formContext } = ownProps;

  const { form, askVA } = state;
  const formData = form.data;
      Severity: Major
      Found in src/applications/ask-va/containers/ReviewPage.jsx - About 5 hrs to fix

        Function ReviewPage has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        const ReviewPage = props => {
  const [showAlert, setShowAlert] = useState(true);
  const dispatch = useDispatch();

  const scrollToChapter = chapterKey => {
        Severity: Minor
        Found in src/applications/ask-va/containers/ReviewPage.jsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function chapters has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            .map(chapterName => {
      const pages = pagesByChapter[chapterName];
      const expandedPages = getActiveExpandedPages(pages, formData);
      const chapterFormConfig = getChapterFormConfigAskVa(
        modifiedFormConfig,
        Severity: Minor
        Found in src/applications/ask-va/containers/ReviewPage.jsx - About 1 hr to fix

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  {props.chapters
          .filter(chapter => chapter.name === 'yourQuestion')
          .map(chapter => {
            return (
              <VaAccordionItem
          Severity: Major
          Found in src/applications/ask-va/containers/ReviewPage.jsx and 4 other locations - About 1 day to fix
          src/applications/ask-va/containers/ReviewPage.jsx on lines 143..175
          src/applications/ask-va/containers/ReviewPage.jsx on lines 177..209
          src/applications/ask-va/containers/ReviewPage.jsx on lines 211..243
          src/applications/ask-va/containers/ReviewPage.jsx on lines 245..277

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 284.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  {props.chapters
          .filter(chapter => chapter.name === 'veteransInformation')
          .map(chapter => {
            return (
              <VaAccordionItem
          Severity: Major
          Found in src/applications/ask-va/containers/ReviewPage.jsx and 4 other locations - About 1 day to fix
          src/applications/ask-va/containers/ReviewPage.jsx on lines 109..141
          src/applications/ask-va/containers/ReviewPage.jsx on lines 143..175
          src/applications/ask-va/containers/ReviewPage.jsx on lines 211..243
          src/applications/ask-va/containers/ReviewPage.jsx on lines 245..277

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 284.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  {props.chapters
          .filter(chapter => chapter.name === 'relationshipToTheVeteran')
          .map(chapter => {
            return (
              <VaAccordionItem
          Severity: Major
          Found in src/applications/ask-va/containers/ReviewPage.jsx and 4 other locations - About 1 day to fix
          src/applications/ask-va/containers/ReviewPage.jsx on lines 109..141
          src/applications/ask-va/containers/ReviewPage.jsx on lines 177..209
          src/applications/ask-va/containers/ReviewPage.jsx on lines 211..243
          src/applications/ask-va/containers/ReviewPage.jsx on lines 245..277

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 284.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  {props.chapters
          .filter(chapter => chapter.name === 'familyMembersInformation')
          .map(chapter => {
            return (
              <VaAccordionItem
          Severity: Major
          Found in src/applications/ask-va/containers/ReviewPage.jsx and 4 other locations - About 1 day to fix
          src/applications/ask-va/containers/ReviewPage.jsx on lines 109..141
          src/applications/ask-va/containers/ReviewPage.jsx on lines 143..175
          src/applications/ask-va/containers/ReviewPage.jsx on lines 177..209
          src/applications/ask-va/containers/ReviewPage.jsx on lines 245..277

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 284.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  {props.chapters
          .filter(chapter => chapter.name === 'yourInformation')
          .map(chapter => {
            return (
              <VaAccordionItem
          Severity: Major
          Found in src/applications/ask-va/containers/ReviewPage.jsx and 4 other locations - About 1 day to fix
          src/applications/ask-va/containers/ReviewPage.jsx on lines 109..141
          src/applications/ask-va/containers/ReviewPage.jsx on lines 143..175
          src/applications/ask-va/containers/ReviewPage.jsx on lines 177..209
          src/applications/ask-va/containers/ReviewPage.jsx on lines 211..243

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 284.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                return {
        expandedPages: expandedPages.map(
          page =>
            page.appStateSelector
              ? { ...page, appStateData: page.appStateSelector(state) }
          Severity: Major
          Found in src/applications/ask-va/containers/ReviewPage.jsx and 1 other location - About 1 hr to fix
          src/platform/forms-system/src/js/review/ReviewChapters.jsx on lines 128..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    <VaAlert
            closeBtnAriaLabel="Close notification"
            closeable
            onCloseEvent={() => setShowAlert(false)}
            status="info"
          Severity: Major
          Found in src/applications/ask-va/containers/ReviewPage.jsx and 1 other location - About 1 hr to fix
          src/applications/fry-dea/components/ConfirmationResponses.jsx on lines 57..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status