department-of-veterans-affairs/vets-website

View on GitHub
src/applications/avs/components/YourHealthInformation.jsx

Summary

Maintainability
D
2 days
Test Coverage

File YourHealthInformation.jsx has 446 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import PropTypes from 'prop-types';
import { useSelector } from 'react-redux';

import { CONTACTS } from '@department-of-veterans-affairs/component-library/contacts';
Severity: Minor
Found in src/applications/avs/components/YourHealthInformation.jsx - About 6 hrs to fix

    Function medsIntro has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const medsIntro = (avs, fullState) => {
      return (
        <>
          <p>
            The medications listed below were reviewed with you by your provider and
    Severity: Major
    Found in src/applications/avs/components/YourHealthInformation.jsx - About 2 hrs to fix

      Function YourHealthInformation has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const YourHealthInformation = props => {
        const { avs } = props;
        const fullState = useSelector(state => state);
      
        const appointmentDate = getFormattedAppointmentDate(avs);
      Severity: Major
      Found in src/applications/avs/components/YourHealthInformation.jsx - About 2 hrs to fix

        Function appointments has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const appointments = avs => {
          if (avs.appointments?.length > 0) {
            const scheduledAppointments = getAppointmentContent(
              APPOINTMENT_TYPES.SCHEDULED,
              avs.appointments,
        Severity: Minor
        Found in src/applications/avs/components/YourHealthInformation.jsx - About 1 hr to fix

          Function renderVaMedication has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const renderVaMedication = medication => {
            const facilityPhone = normalizePhoneNumber(medication.facilityPhone);
            const phoneNotClickable = !numberIsClickable(facilityPhone);
          
            return (
          Severity: Minor
          Found in src/applications/avs/components/YourHealthInformation.jsx - About 1 hr to fix

            Function labResults has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const labResults = avs => {
              if (avs.labResults?.length > 0) {
                const labResultItems = avs.labResults.map((item, idx) => (
                  <div key={idx}>
                    {labResultValues(item.values)}
            Severity: Minor
            Found in src/applications/avs/components/YourHealthInformation.jsx - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      {scheduledAppointments && (
                        <div>
                          <h4>Scheduled appointments</h4>
                          <p>Appointments in the next 13 months:</p>
                          <ul
              Severity: Major
              Found in src/applications/avs/components/YourHealthInformation.jsx and 1 other location - About 1 hr to fix
              src/applications/avs/components/YourHealthInformation.jsx on lines 125..142

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 71.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      {recallAppointments && (
                        <div>
                          <h4>Recall appointments</h4>
                          <p>
                            Please know that Recall appointments are not confirmed
              Severity: Major
              Found in src/applications/avs/components/YourHealthInformation.jsx and 1 other location - About 1 hr to fix
              src/applications/avs/components/YourHealthInformation.jsx on lines 113..124

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 71.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status