Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/caregivers/config/submit-transformer.js

Summary

Maintainability
B
7 hrs
Test Coverage

Function submitTransformer has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const submitTransformer = (formConfig, form) => {
  const { data: formData } = form;
  const primaryKey = formData['view:hasPrimaryCaregiver'] ? 'primary' : null;
  const SecondaryOneKey = formData['view:hasSecondaryCaregiverOne']
    ? 'secondaryOne'
Severity: Major
Found in src/applications/caregivers/config/submit-transformer.js - About 3 hrs to fix

    Function submitTransformer has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    const submitTransformer = (formConfig, form) => {
  const { data: formData } = form;
  const primaryKey = formData['view:hasPrimaryCaregiver'] ? 'primary' : null;
  const SecondaryOneKey = formData['view:hasSecondaryCaregiverOne']
    ? 'secondaryOne'
    Severity: Minor
    Found in src/applications/caregivers/config/submit-transformer.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function buildChapterSortedObject has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const buildChapterSortedObject = dataPrefix => {
    // check to make sure there is a keyName
    if (dataPrefix === null) return {};

    // matches prefix to fullSchema chapter object labels/keys
    Severity: Minor
    Found in src/applications/caregivers/config/submit-transformer.js - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status