department-of-veterans-affairs/vets-website

View on GitHub
src/applications/check-in/components/layout/Wrapper.jsx

Summary

Maintainability
B
4 hrs
Test Coverage

Function Wrapper has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const Wrapper = props => {
  const {
    children,
    pageTitle,
    titleOverride,
Severity: Major
Found in src/applications/check-in/components/layout/Wrapper.jsx - About 2 hrs to fix

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

    Wrapper.propTypes = {
      children: PropTypes.node,
      classNames: PropTypes.string,
      eyebrow: PropTypes.string,
      pageTitle: PropTypes.string,
    Severity: Major
    Found in src/applications/check-in/components/layout/Wrapper.jsx and 14 other locations - About 2 hrs to fix
    src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskGreen/EditContactInfoTaskGreen.jsx on lines 123..131
    src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskYellow/EditMailingAddressTaskYellow.jsx on lines 106..114
    src/applications/_mock-form-ae-design-patterns/patterns/pattern1/ezr/EditContactInfo.jsx on lines 123..131
    src/applications/caregivers/components/FormFields/AddressWithAutofill.jsx on lines 228..236
    src/applications/financial-status-report/components/employment/EmploymentRecord.jsx on lines 199..207
    src/applications/financial-status-report/components/shared/ContactInfoCard.jsx on lines 36..44
    src/applications/gi/components/ClearFiltersBtn.jsx on lines 86..94
    src/applications/hca/containers/IdentityPage.jsx on lines 142..150
    src/applications/letters/containers/Main.jsx on lines 72..80
    src/applications/personalization/dashboard/components/health-care/HealthCareCTA.jsx on lines 146..154
    src/applications/terms-of-use/components/TermsAcceptanceAction.jsx on lines 60..68
    src/applications/travel-pay/components/TravelClaimCard.jsx on lines 57..65
    src/applications/vaos/covid-19-vaccine/components/ContactInfoPage.jsx on lines 123..131
    src/applications/vaos/new-appointment/components/CommunityCareProviderSelectionPage/ProviderSelect.jsx on lines 94..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status