Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/check-in/components/pages/UpcomingAppointments/UpcomingAppointmentsPage.unit.spec.jsx

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('shows the date & time the appointments were loaded and a refresh link', () => {
      const checkIn = render(
        <CheckInProvider store={{ features: appointmentsOn }}>
          <UpcomingAppointmentsPage />
        </CheckInProvider>,
Severity: Major
Found in src/applications/check-in/components/pages/UpcomingAppointments/UpcomingAppointmentsPage.unit.spec.jsx and 1 other location - About 4 hrs to fix
src/applications/check-in/components/pages/Appointments/AppointmentsPage.unit.spec.jsx on lines 66..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 134.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('shows a privacy act modal if the link is clicked', () => {
      const checkIn = render(
        <CheckInProvider store={{ features: appointmentsOn }}>
          <UpcomingAppointmentsPage />
        </CheckInProvider>,
Severity: Major
Found in src/applications/check-in/components/pages/UpcomingAppointments/UpcomingAppointmentsPage.unit.spec.jsx and 1 other location - About 4 hrs to fix
src/applications/check-in/components/pages/Appointments/AppointmentsPage.unit.spec.jsx on lines 90..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('shows pre-check-in alert message when there are upcoming appointments', () => {
      const { getByTestId } = render(
        <CheckInProvider
          store={{
            upcomingAppointments: multipleAppointments,
Severity: Major
Found in src/applications/check-in/components/pages/UpcomingAppointments/UpcomingAppointmentsPage.unit.spec.jsx and 1 other location - About 3 hrs to fix
src/applications/check-in/components/pages/UpcomingAppointments/UpcomingAppointmentsPage.unit.spec.jsx on lines 198..213

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 114.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('shows check-in alert message when there are upcoming appointments', () => {
      const { getByTestId } = render(
        <CheckInProvider
          store={{
            upcomingAppointments: multipleAppointments,
Severity: Major
Found in src/applications/check-in/components/pages/UpcomingAppointments/UpcomingAppointmentsPage.unit.spec.jsx and 1 other location - About 3 hrs to fix
src/applications/check-in/components/pages/UpcomingAppointments/UpcomingAppointmentsPage.unit.spec.jsx on lines 182..197

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 114.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      const { getByTestId } = render(
        <CheckInProvider store={{ features: appointmentsOn }}>
          <UpcomingAppointmentsPage />
        </CheckInProvider>,
      );
Severity: Major
Found in src/applications/check-in/components/pages/UpcomingAppointments/UpcomingAppointmentsPage.unit.spec.jsx and 2 other locations - About 40 mins to fix
src/applications/check-in/components/pages/Appointments/AppointmentsPage.unit.spec.jsx on lines 34..38
src/applications/check-in/components/pages/UpcomingAppointments/UpcomingAppointmentsPage.unit.spec.jsx on lines 73..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      const { getByTestId } = render(
        <CheckInProvider store={{ features: appointmentsOn }}>
          <UpcomingAppointmentsPage />
        </CheckInProvider>,
      );
Severity: Major
Found in src/applications/check-in/components/pages/UpcomingAppointments/UpcomingAppointmentsPage.unit.spec.jsx and 2 other locations - About 40 mins to fix
src/applications/check-in/components/pages/Appointments/AppointmentsPage.unit.spec.jsx on lines 34..38
src/applications/check-in/components/pages/UpcomingAppointments/UpcomingAppointmentsPage.unit.spec.jsx on lines 27..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      const screen = render(
        <CheckInProvider
          store={{ upcomingAppointments: [], features: appointmentsOn }}
        >
          <UpcomingAppointmentsPage />
Severity: Minor
Found in src/applications/check-in/components/pages/UpcomingAppointments/UpcomingAppointmentsPage.unit.spec.jsx and 1 other location - About 40 mins to fix
src/applications/check-in/components/pages/Appointments/AppointmentsPage.unit.spec.jsx on lines 56..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status