Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/claims-status/components/StemDeniedDetails.jsx

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        <li className="stem-ad-list-item">
          You didn’t meet the benefit requirements for the Rogers STEM
          Scholarship.
          <ul className="stem-ad-list-secondary">
            <li className="stem-ad-list-item">
Severity: Major
Found in src/applications/claims-status/components/StemDeniedDetails.jsx and 1 other location - About 2 hrs to fix
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 61..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        <li className="stem-ad-list-item">
          You’re eligible for Post-9/11 GI Bill benefits.
          <ul className="stem-ad-list-secondary">
            <li className="stem-ad-list-item">
              According to your service and school data records on file, as of{' '}
Severity: Major
Found in src/applications/claims-status/components/StemDeniedDetails.jsx and 1 other location - About 2 hrs to fix
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 40..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

              <li className="stem-ad-list-item">
                You meet the degree requirements because you answered "Yes" to
                one of these questions on the Rogers STEM Scholarship
                application.
                <ul>
Severity: Major
Found in src/applications/claims-status/components/StemDeniedDetails.jsx and 4 other locations - About 1 hr to fix
src/applications/burial-poc-v6/pages/BurialIntroduction.jsx on lines 74..82
src/applications/disability-benefits/all-claims/content/unemployabilityFormIntro.jsx on lines 23..36
src/applications/disability-benefits/all-claims/content/unemployabilityFormIntro.jsx on lines 37..49
src/applications/ivc-champva/10-7959f-1/containers/IntroductionPage.jsx on lines 34..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

                <ol>
                  <li>
                    Be enrolled in an eligible STEM undergraduate degree,{' '}
                    <strong>or</strong>
                  </li>
Severity: Major
Found in src/applications/claims-status/components/StemDeniedDetails.jsx and 7 other locations - About 1 hr to fix
src/applications/coronavirus-screener/config/questions.jsx on lines 185..191
src/applications/enrollment-verification/containers/EnrollmentVerificationIntroPage.jsx on lines 127..133
src/applications/mhv-medications/components/shared/StatusDropdown.jsx on lines 139..145
src/applications/pensions/config/chapters/06-additional-information/supportingDocuments.js on lines 185..196
src/applications/post-911-gib-status/utils/helpers.jsx on lines 72..78
src/applications/simple-forms/20-10207/containers/IntroductionPage.jsx on lines 125..131
src/applications/simple-forms/21-0966/containers/IntroductionPage.jsx on lines 37..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        <li className="stem-ad-list-item">
          If you have new or previously unprovided evidence to prove your
          eligibility for this scholarship, you can file a Supplemental Claim by
          completing VA Form 20-0995.{' '}
          <a
Severity: Major
Found in src/applications/claims-status/components/StemDeniedDetails.jsx and 2 other locations - About 55 mins to fix
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 134..147
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 148..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        <li className="stem-ad-list-item">
          If you don’t have new evidence but would like a more senior reviewer
          to look at your case, you can request a Higher-Level Review by
          completing VA Form 20-0996.{' '}
          <a
Severity: Major
Found in src/applications/claims-status/components/StemDeniedDetails.jsx and 2 other locations - About 55 mins to fix
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 120..133
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 148..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        <li className="stem-ad-list-item">
          If you filed a Supplemental Claim or Higher-Level Review and don’t
          agree with the decision, you can appeal to a Veterans Law Judge by
          completing VA Form 10182.{' '}
          <a
Severity: Major
Found in src/applications/claims-status/components/StemDeniedDetails.jsx and 2 other locations - About 55 mins to fix
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 120..133
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 134..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        <a
          data-testid="gi-bill-comp-tool-link"
          href="https://www.va.gov/education/gi-bill-comparison-tool"
          onClick={() => {
            recordResourceLinkClick(
Severity: Minor
Found in src/applications/claims-status/components/StemDeniedDetails.jsx and 2 other locations - About 35 mins to fix
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 192..204
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 208..217

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        <a
          data-testid="edith-north-rodgers-stem-link"
          href="https://www.va.gov/education/other-va-education-benefits/stem-scholarship/"
          onClick={() => {
            recordResourceLinkClick(
Severity: Minor
Found in src/applications/claims-status/components/StemDeniedDetails.jsx and 2 other locations - About 35 mins to fix
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 208..217
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 221..233

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        <a
          data-testid="find-va-form-link"
          href="https://www.va.gov/vaforms"
          onClick={() => {
            recordResourceLinkClick('Find a VA Form', 'Search for a VA form.');
Severity: Minor
Found in src/applications/claims-status/components/StemDeniedDetails.jsx and 2 other locations - About 35 mins to fix
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 192..204
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 221..233

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status