Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/disability-benefits/all-claims/content/confirmation-page.jsx

Summary

Maintainability
C
1 day
Test Coverage

Function template has 187 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const template = (props, title, content, submissionMessage, messageType) => {
  const { fullName, disabilities, submittedAt, isSubmittingBDD } = props;
  const { first, last, middle, suffix } = fullName;
  // This is easier than passing down props and checking if the form type
  const pageTitle = document.title.includes('Benefits')
Severity: Major
Found in src/applications/disability-benefits/all-claims/content/confirmation-page.jsx - About 7 hrs to fix

    File confirmation-page.jsx has 262 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React from 'react';

import { CONTACTS } from '@department-of-veterans-affairs/component-library/contacts';

import DownloadPDF from '../components/DownloadPDF';
    Severity: Minor
    Found in src/applications/disability-benefits/all-claims/content/confirmation-page.jsx - About 2 hrs to fix

      Function submitErrorContent has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const submitErrorContent = props => {
  const submissionIdContent = props.submissionId
    ? ` and provide this reference number ${props.submissionId}`
    : '';
      Severity: Minor
      Found in src/applications/disability-benefits/all-claims/content/confirmation-page.jsx - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              <div className="print-only">
        <img
          src="https://www.va.gov/img/design/logo/logo-black-and-white.png"
          alt="VA logo"
          width="300"
        Severity: Major
        Found in src/applications/disability-benefits/all-claims/content/confirmation-page.jsx and 1 other location - About 1 hr to fix
        src/applications/appeals/shared/components/ConfirmationDecisionReviews.jsx on lines 52..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status