Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/education-letters/containers/InboxPage.jsx

Summary

Maintainability
C
7 hrs
Test Coverage

Function renderInbox has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  const renderInbox = () => {
    if (
      MEBClaimStatusFetchInProgress ||
      TOEClaimStatusFetchInProgress ||
      !isLoggedIn.current
Severity: Minor
Found in src/applications/education-letters/containers/InboxPage.jsx - About 1 hr to fix

    Function InboxPage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    const InboxPage = ({
  claimStatus,
  getClaimStatus,
  user,
  MEBClaimStatusFetchInProgress,
    Severity: Minor
    Found in src/applications/education-letters/containers/InboxPage.jsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function mapStateToProps has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const mapStateToProps = state => {
  const { MEBClaimStatus, TOEClaimStatus } = state?.data;
  let latestClaim;

  if (
    Severity: Minor
    Found in src/applications/education-letters/containers/InboxPage.jsx - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

          return false;
      Severity: Major
      Found in src/applications/education-letters/containers/InboxPage.jsx - About 30 mins to fix

        Similar blocks of code found in 11 locations. Consider refactoring.
        Open

        InboxPage.propTypes = {
  claimStatus: PropTypes.object,
  getClaimStatus: PropTypes.func,
  MEBClaimStatusFetchInProgress: PropTypes.bool,
  MEBClaimStatusFetchComplete: PropTypes.bool,
        Severity: Major
        Found in src/applications/education-letters/containers/InboxPage.jsx and 10 other locations - About 2 hrs to fix
        src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/EditContactInfo.jsx on lines 112..121
        src/applications/gi/containers/search/LocationSearchResults.jsx on lines 859..868
        src/applications/mhv-secure-messaging/components/Search/FilterBox.jsx on lines 165..174
        src/applications/mhv-secure-messaging/components/ThreadList/ThreadsList.jsx on lines 116..125
        src/applications/personalization/dashboard/components/CTALink.jsx on lines 43..52
        src/applications/personalization/view-dependents/layouts/ViewDependentsLayout.jsx on lines 72..81
        src/applications/personalization/view-dependents/manage-dependents/containers/ManageDependentsApp.jsx on lines 148..157
        src/applications/toe/containers/SponsorsSelectionPage.jsx on lines 98..107
        src/applications/travel-pay/components/TravelPayClaimFilters.jsx on lines 58..67
        src/platform/forms/components/review/FormSaveErrorMessage.jsx on lines 129..138

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 84.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status