Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/enrollment-verification/containers/EnrollmentVerificationIntroPage.jsx

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 7 locations. Consider refactoring.
Open

      <ul>
        <li>
          Montgomery GI Bill - Active Duty (MGIB-AD, Chapter 30),{' '}
          <strong>or</strong>
        </li>
Severity: Major
Found in src/applications/enrollment-verification/containers/EnrollmentVerificationIntroPage.jsx and 6 other locations - About 1 hr to fix
src/applications/claims-status/components/StemDeniedDetails.jsx on lines 96..105
src/applications/coronavirus-screener/config/questions.jsx on lines 185..191
src/applications/mhv-medications/components/shared/StatusDropdown.jsx on lines 139..145
src/applications/pensions/config/chapters/06-additional-information/supportingDocuments.js on lines 185..196
src/applications/simple-forms/20-10207/containers/IntroductionPage.jsx on lines 125..131
src/applications/simple-forms/21-0966/containers/IntroductionPage.jsx on lines 37..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      <p>
        <strong>Note</strong>: If you need to update your primary phone number,
        call us at <va-telephone contact="8884424551" />. We’re here Monday
        through Friday, 8:00 a.m. to 7:00 p.m. ET. If you have hearing loss,
        call <va-telephone contact="711" />.
Severity: Minor
Found in src/applications/enrollment-verification/containers/EnrollmentVerificationIntroPage.jsx and 1 other location - About 50 mins to fix
src/applications/personalization/profile/components/direct-deposit/alerts/VerifyIdentity.jsx on lines 62..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status