Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/facility-locator/containers/FacilitiesMap.jsx

Summary

Maintainability
F
6 days
Test Coverage

Function FacilitiesMap has 529 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const FacilitiesMap = props => {
  const [map, setMap] = useState(null);
  const searchResultTitleRef = useRef(null);
  const [isMobile, setIsMobile] = useState(window.innerWidth <= 481);
  const [isSearching, setIsSearching] = useState(false);
Severity: Major
Found in src/applications/facility-locator/containers/FacilitiesMap.jsx - About 2 days to fix

    Function FacilitiesMap has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring.
    Open

    const FacilitiesMap = props => {
  const [map, setMap] = useState(null);
  const searchResultTitleRef = useRef(null);
  const [isMobile, setIsMobile] = useState(window.innerWidth <= 481);
  const [isSearching, setIsSearching] = useState(false);
    Severity: Minor
    Found in src/applications/facility-locator/containers/FacilitiesMap.jsx - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File FacilitiesMap.jsx has 613 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React, { useEffect, useRef, useState } from 'react';
import { connect } from 'react-redux';
import appendQuery from 'append-query';
import mapboxgl from 'mapbox-gl';
import 'mapbox-gl/dist/mapbox-gl.css';
    Severity: Major
    Found in src/applications/facility-locator/containers/FacilitiesMap.jsx - About 1 day to fix

      Function renderView has 133 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const renderView = () => {
    // This block renders the desktop and mobile view. It ensures that the desktop map
    // gets re-loaded when resizing from mobile to desktop.
    const {
      currentQuery,
      Severity: Major
      Found in src/applications/facility-locator/containers/FacilitiesMap.jsx - About 5 hrs to fix

        Function renderMarkers has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          const renderMarkers = locations => {
    if (locations.length === 0) return;
    const markersLetters = MARKER_LETTERS.values();

    const locationBounds = new mapboxgl.LngLatBounds();
        Severity: Minor
        Found in src/applications/facility-locator/containers/FacilitiesMap.jsx - About 1 hr to fix

          Function setupMap has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const setupMap = () => {
    const mapContainerElement = document.getElementById(mapboxGlContainer);
    if (!mapContainerElement) {
      return null;
    }
          Severity: Minor
          Found in src/applications/facility-locator/containers/FacilitiesMap.jsx - About 1 hr to fix

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

            const mapDispatchToProps = {
  geolocateUser,
  clearGeocodeError,
  fetchVAFacility,
  updateSearchQuery,
            Severity: Major
            Found in src/applications/facility-locator/containers/FacilitiesMap.jsx and 4 other locations - About 1 hr to fix
            src/applications/ask-va/config/schema-helpers/formFlowHelper.js on lines 379..390
            src/applications/claims-status/components/claim-files-tab/AdditionalEvidencePage.jsx on lines 219..230
            src/applications/appeals/shared/props.js on lines 65..76
            src/platform/forms-system/src/js/patterns/array-builder/arrayBuilder.jsx on lines 393..404

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  return (
        <PaginationWrapper
          handlePageSelect={handlePageSelect}
          currentPage={currentPage}
          totalPages={totalPages}
            Severity: Minor
            Found in src/applications/facility-locator/containers/FacilitiesMap.jsx and 1 other location - About 40 mins to fix
            src/applications/representative-search/containers/SearchPage.jsx on lines 411..419

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status