Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/facility-locator/utils/helpers.jsx

Summary

Maintainability
C
1 day
Test Coverage

Function formatOperatingHours has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const formatOperatingHours = operatingHours => {
  if (!operatingHours) return operatingHours;
  // Remove all whitespace and sanitize dashes.
  const sanitizedOperatingHours = operatingHours
    .replace(/ /g, '')
Severity: Major
Found in src/applications/facility-locator/utils/helpers.jsx - About 2 hrs to fix

    Function formatOperatingHours has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    export const formatOperatingHours = operatingHours => {
  if (!operatingHours) return operatingHours;
  // Remove all whitespace and sanitize dashes.
  const sanitizedOperatingHours = operatingHours
    .replace(/ /g, '')
    Severity: Minor
    Found in src/applications/facility-locator/utils/helpers.jsx - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function buildMarker has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const buildMarker = (type, values) => {
  if (type === 'location') {
    const { loc, attrs } = values;
    const markerElement = document.createElement('span');
    markerElement.className = 'i-pin-card-map';
    Severity: Minor
    Found in src/applications/facility-locator/utils/helpers.jsx - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

        if (
    sanitizedOperatingHours.search(/ByAppointmentOnly/i) === 0 ||
    sanitizedOperatingHours.search(/AppointmentsOnly/i) === 0 ||
    sanitizedOperatingHours.search(/PleaseCallforHours/i) === 0 ||
    sanitizedOperatingHours.search(
      Severity: Major
      Found in src/applications/facility-locator/utils/helpers.jsx - About 40 mins to fix

        Consider simplifying this complex logical expression.
        Open

          if (
    (formattedOpeningHour.search(/Invalid date/i) !== 0 &&
      formattedClosingHour.search(/Invalid date/i) !== 0) ||
    (formattedOpeningHour.search(/Invalid date/i) !== 0 &&
      formattedClosingHour.search(/Invalid date/i) === 0) ||
        Severity: Major
        Found in src/applications/facility-locator/utils/helpers.jsx - About 40 mins to fix

          Function setFocus has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          export const setFocus = (selector, tabIndexInclude = true) => {
  const el =
    typeof selector === 'string' ? document.querySelector(selector) : selector;
  if (el) {
    if (
          Severity: Minor
          Found in src/applications/facility-locator/utils/helpers.jsx - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

              return operatingHours;
          Severity: Major
          Found in src/applications/facility-locator/utils/helpers.jsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              return formattedOperatingHours;
            Severity: Major
            Found in src/applications/facility-locator/utils/helpers.jsx - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return 'Closed';
              Severity: Major
              Found in src/applications/facility-locator/utils/helpers.jsx - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return operatingHours;
                Severity: Major
                Found in src/applications/facility-locator/utils/helpers.jsx - About 30 mins to fix

                  There are no issues that match your filters.

                  Category
                  Status