Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx

Summary

Maintainability
F
4 days
Test Coverage

Function InstallmentContract has 284 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const InstallmentContract = props => {
  const { data, goToPath, setFormData } = props;

  const { installmentContracts = [] } = data;
Severity: Major
Found in src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx - About 1 day to fix

    Function InstallmentContract has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

    const InstallmentContract = props => {
  const { data, goToPath, setFormData } = props;

  const { installmentContracts = [] } = data;
    Severity: Minor
    Found in src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File InstallmentContract.jsx has 330 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React, { useState } from 'react';
import PropTypes from 'prop-types';
import { connect } from 'react-redux';
import { setData } from 'platform/forms-system/src/js/actions';
import {
    Severity: Minor
    Found in src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx - About 3 hrs to fix

      Function updateFormData has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const updateFormData = e => {
    setSubmitted(true);
    e.preventDefault();

    const loanBeganContainsGoodValue = validateLoanBegan(
      Severity: Minor
      Found in src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          const renderAddCancelButtons = () => {
    return (
      <>
        <ButtonGroup
          buttons={[
        Severity: Major
        Found in src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx and 1 other location - About 2 hrs to fix
        src/applications/financial-status-report/components/householdExpenses/CreditCardBill.jsx on lines 158..177

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 88.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                <legend className="schemaform-block-title">
          <h3 className="vads-u-margin--0">
            {`${
              installmentContracts.length === index ? 'Add' : 'Update'
            } an installment contract or other debt`}
        Severity: Major
        Found in src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx and 1 other location - About 2 hrs to fix
        src/applications/financial-status-report/components/householdExpenses/CreditCardBill.jsx on lines 203..212

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 80.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          const renderContinueBackButtons = () => {
    return (
      <>
        <ButtonGroup
          buttons={[
        Severity: Major
        Found in src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx and 1 other location - About 2 hrs to fix
        src/applications/financial-status-report/components/householdExpenses/CreditCardBill.jsx on lines 179..198

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                <va-text-input
          hint={null}
          currency
          inputmode="decimal"
          label="Original loan amount"
        Severity: Major
        Found in src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx and 1 other location - About 1 hr to fix
        src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx on lines 340..351

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                <va-text-input
          hint={null}
          currency
          inputmode="decimal"
          label="Amount overdue"
        Severity: Major
        Found in src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx and 1 other location - About 1 hr to fix
        src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx on lines 274..285

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            onCancel: event => {
      event.preventDefault();
      if (installmentContracts.length === 0) {
        goToPath(START_PATH);
      } else {
        Severity: Minor
        Found in src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx and 1 other location - About 55 mins to fix
        src/applications/financial-status-report/components/householdExpenses/CreditCardBill.jsx on lines 137..144

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          const amountDueMonthlyError =
    !isValidCurrency(contractRecord.amountDueMonthly) ||
    (contractRecord.amountDueMonthly > MAXIMUM_INSTALLMENT_AMOUNT ||
      contractRecord.amountDueMonthly < 0)
      ? 'Please enter a minimum monthly payment amount less than $1,000,000'
        Severity: Minor
        Found in src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx and 2 other locations - About 35 mins to fix
        src/applications/financial-status-report/components/householdExpenses/CreditCardBill.jsx on lines 50..55
        src/applications/financial-status-report/components/householdExpenses/CreditCardBill.jsx on lines 57..62

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        const defaultRecord = [
  {
    purpose: '',
    creditorName: '',
    originalAmount: '',
        Severity: Minor
        Found in src/applications/financial-status-report/components/householdExpenses/InstallmentContract.jsx and 1 other location - About 30 mins to fix
        src/applications/financial-status-report/components/householdExpenses/CreditCardBill.jsx on lines 8..18

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status